Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1557155

Re: [PATCH] tty_port: checkpatch: Refactored file to linux style guides

Show all headers | View raw

On Wed, Jan 11, 2017 at 10:39:22PM +0100, Fabian Arnold wrote:
> The tty_port.c file is now accordingly to the linux style guidelines.

That's the vaguest changelog text ever :(

Please describe what you did here, and why you did it.  And if you fixed
more than one "type" of style issue, you need to break this up into
multiple patches.

And finally, why are you doing checkpatch cleanup on core kernel code?
Please start in drivers/staging/ where it's more appreciated and you can
learn how to do it correctly, that's what that code is there for.

thanks,

greg k-h

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] tty_port: checkpatch: Refactored file to linux style guides Fabian Arnold <fabian.arnold@fau.de> - 2017-01-11 22:40 +0100
  Re: [PATCH] tty_port: checkpatch: Refactored file to linux style  guides Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-01-12 08:50 +0100

csiph-web