Re: [PATCH] staging: android/ion: Fix coding style issues

From	Greg KH <gregkh@linuxfoundation.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] staging: android/ion: Fix coding style issues
Date	2017-01-12 08:40 +0100
Message-ID	<sYI9k-1aH-11@gated-at.bofh.it> (permalink)
References	<sYyCZ-3As-35@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Jan 11, 2017 at 11:20:39PM +0200, Bogdan Purcareata wrote:
> Fix following checkpatch warnings:
> - Lines over 80 characters
> - void function with return statement
> - Unaligned comment mark
> - Header function prototypes missing variable names

That's a lot of different things to be doing all in one patch.  Please
break this up into "one-logical-thing-per-patch" and send this as a
patch series.

And no, "fix coding style issues" is not "one logical thing".

thanks,

greg k-h

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] staging: android/ion: Fix coding style issues Bogdan Purcareata <bogdan.purcareata@gmail.com> - 2017-01-11 22:30 +0100
  Re: [PATCH] staging: android/ion: Fix coding style issues Greg KH <gregkh@linuxfoundation.org> - 2017-01-12 08:40 +0100

csiph-web