Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1557042

Re: [PATCH v5 2/9] mm/swap: Add cluster lock

Show all headers | View raw

Hi, Jonathan,

Jonathan Corbet <corbet@lwn.net> writes:

> On Wed, 11 Jan 2017 15:00:29 -0800
> Andrew Morton <akpm@linux-foundation.org> wrote:
>
>> hm, bit_spin_lock() is a nasty thing.  It is slow and it doesn't have
>> all the lockdep support.
>> 
>> Would the world end if we added a spinlock to swap_cluster_info?
>
> FWIW, I asked the same question in December, this is what I got:

Sorry I made a mistake in the following email.  I have sent another
email to correct this before from my another email address,
huang.ying.caritas@gmail.com, have you received it, copied below,

From: huang ying <huang.ying.caritas@gmail.com>
Subject: Re: [PATCH v2 2/8] mm/swap: Add cluster lock
To: "Huang, Ying" <ying.huang@intel.com>
CC: Jonathan Corbet <corbet@lwn.net>, Tim Chen <tim.c.chen@linux.intel.com>,
	Andrew Morton <akpm@linux-foundation.org>, <dave.hansen@intel.com>, "Andi
 Kleen" <ak@linux.intel.com>, Aaron Lu <aaron.lu@intel.com>,
	<linux-mm@kvack.org>, LKML <linux-kernel@vger.kernel.org>, Hugh Dickins
	<hughd@google.com>, Shaohua Li <shli@kernel.org>, Minchan Kim
	<minchan@kernel.org>, Rik van Riel <riel@redhat.com>, Andrea Arcangeli
	<aarcange@redhat.com>, "Kirill A . Shutemov"
	<kirill.shutemov@linux.intel.com>, Vladimir Davydov <vdavydov.dev@gmail.com>,
	Johannes Weiner <hannes@cmpxchg.org>, Michal Hocko <mhocko@kernel.org>, Hillf
 Danton <hillf.zj@alibaba-inc.com>
Date: Wed, 28 Dec 2016 11:34:01 +0800 (2 weeks, 21 hours, 45 minutes ago)

Hi, Jonathan,

On Tue, Oct 25, 2016 at 10:05 AM, Huang, Ying <ying.huang@intel.com> wrote:
> Hi, Jonathan,
>
> Thanks for review.
>
> Jonathan Corbet <corbet@lwn.net> writes:
>
>> On Thu, 20 Oct 2016 16:31:41 -0700
>> Tim Chen <tim.c.chen@linux.intel.com> wrote:
>>
>>> From: "Huang, Ying" <ying.huang@intel.com>
>>>
>>> This patch is to reduce the lock contention of swap_info_struct->lock
>>> via using a more fine grained lock in swap_cluster_info for some swap
>>> operations.  swap_info_struct->lock is heavily contended if multiple

[...]

>> The cost, of course, is the growth of this structure, but you've already
>> noted that the overhead isn't all that high; seems like it could be worth
>> it.
>
> Yes.  The data structure you proposed is much easier to be used than the
> current one.  The main concern is the RAM usage.  The size of the data
> structure you proposed is about 80 bytes, while that of the current one
> is about 8 bytes.  There will be one struct swap_cluster_info for every
> 1MB swap space, so for 1TB swap space, the total size will be 80M
> compared with 8M of current implementation.

Sorry, I turned on the lockdep when measure the size change, so the
previous size change data is wrong.  The size of the data structure
you proposed is 12 bytes.  While that of the current one is 8 bytes on
64 bit platform and 4 bytes on 32 bit platform.

Best Regards,
Huang, Ying

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v5 0/9] mm/swap: Regular page swap optimizations  Tim Chen <tim.c.chen@linux.intel.com> - 2017-01-11 19:00 +0100
  [PATCH v5 4/9] mm/swap: skip read ahead for unreferenced swap slots Tim Chen <tim.c.chen@linux.intel.com> - 2017-01-11 19:00 +0100
  [PATCH v5 5/9] mm/swap: Allocate swap slots in batches Tim Chen <tim.c.chen@linux.intel.com> - 2017-01-11 19:00 +0100
  [PATCH v5 2/9] mm/swap: Add cluster lock Tim Chen <tim.c.chen@linux.intel.com> - 2017-01-11 19:00 +0100
    Re: [PATCH v5 2/9] mm/swap: Add cluster lock Jonathan Corbet <corbet@lwn.net> - 2017-01-12 00:10 +0100
      Re: [PATCH v5 2/9] mm/swap: Add cluster lock Andrew Morton <akpm@linux-foundation.org> - 2017-01-12 00:20 +0100
        Re: [PATCH v5 2/9] mm/swap: Add cluster lock "Huang\, Ying" <ying.huang@intel.com> - 2017-01-12 02:50 +0100
          Re: [PATCH v5 2/9] mm/swap: Add cluster lock Andrew Morton <akpm@linux-foundation.org> - 2017-01-12 03:00 +0100
            Re: [PATCH v5 2/9] mm/swap: Add cluster lock "Huang\, Ying" <ying.huang@intel.com> - 2017-01-12 04:00 +0100
            [Update][PATCH v5 2/9] mm/swap: Add cluster lock "Huang\, Ying" <ying.huang@intel.com> - 2017-01-14 05:40 +0100
      Re: [PATCH v5 2/9] mm/swap: Add cluster lock "Huang\, Ying" <ying.huang@intel.com> - 2017-01-12 02:30 +0100
    Re: [PATCH v5 2/9] mm/swap: Add cluster lock Andrew Morton <akpm@linux-foundation.org> - 2017-01-12 00:10 +0100
  [PATCH v5 1/9] mm/swap: Fix kernel message in swap_info_get() Tim Chen <tim.c.chen@linux.intel.com> - 2017-01-11 19:00 +0100
  Re: [PATCH v5 0/9] mm/swap: Regular page swap optimizations Michal Hocko <mhocko@kernel.org> - 2017-01-16 13:10 +0100

csiph-web