Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1555807

Re: [PATCH v4 1/2] arm64: dts: rockchip: add "rockchip, grf" property for RK3399 PMUCRU/CRU

Show all headers | View raw

Hi,

On Mon, Jan 9, 2017 at 10:15 PM, Xing Zheng <zhengxing@rock-chips.com> wrote:
> The structure rockchip_clk_provider needs to refer the GRF regmap
> in somewhere, if the CRU node has not "rockchip,grf" property,
> calling syscon_regmap_lookup_by_phandle will return an invalid GRF
> regmap, and the MUXGRF type clock will be not supported.
>
> Therefore, we need to add them.
>
> Signed-off-by: Xing Zheng <zhengxing@rock-chips.com>
> ---
>
> Changes in v4:
> - separte the binding patch
>
> Changes in v3:
> - add optional roperty rockchip,grf in rockchip,rk3399-cru.txt
>
> Changes in v2:
> - referring pmugrf for PMUGRU
> - fix the typo "invaild" in COMMIT message
>
>  arch/arm64/boot/dts/rockchip/rk3399.dtsi | 2 ++
>  1 file changed, 2 insertions(+)

This seems fine to me, so:

Reviewed-by: Douglas Anderson <dianders@chromium.org>

...but I will say that before you actually add any real "MUXGRF"
clocks on rk3399 you _might_ need to rework the code to make things
truly "optional".  If it turns out that any existing clocks that
already exist today already go through one of these muxes in the GRF
and we've always been assuming one setting of the mux, we'll need to
make sure we keep assuming that setting of the mux even if the "grf"
isn't specified.

As I understand it, your motivation for this patch is to eventually be
able to model the EDP reference clock which can either be xin24 or
"edp osc".  Presumably the eDP "reference clock" isn't related to any
of the pre-existing eDP clocks so that one should be safe.

-Doug

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v4 0/2] Add support rockchip,grf property for RK3399 PMU/GRU Xing Zheng <zhengxing@rock-chips.com> - 2017-01-10 07:20 +0100
  [PATCH v4 1/2] arm64: dts: rockchip: add "rockchip, grf" property for RK3399 PMUCRU/CRU Xing Zheng <zhengxing@rock-chips.com> - 2017-01-10 07:20 +0100
    Re: [PATCH v4 1/2] arm64: dts: rockchip: add "rockchip, grf" property  for RK3399 PMUCRU/CRU Doug Anderson <dianders@google.com> - 2017-01-10 19:50 +0100
      Re: [PATCH v4 1/2] arm64: dts: rockchip: add "rockchip, grf" property for RK3399 PMUCRU/CRU Heiko Stübner <heiko@sntech.de> - 2017-01-10 20:50 +0100
        Re: [PATCH v4 1/2] arm64: dts: rockchip: add "rockchip, grf" property for RK3399 PMUCRU/CRU Heiko Stübner <heiko@sntech.de> - 2017-01-10 21:00 +0100
          Re: [PATCH v4 1/2] arm64: dts: rockchip: add "rockchip, grf" property  for RK3399 PMUCRU/CRU Doug Anderson <dianders@google.com> - 2017-01-12 02:00 +0100
            Re: [PATCH v4 1/2] arm64: dts: rockchip: add "rockchip, grf" property for RK3399 PMUCRU/CRU Heiko Stuebner <heiko@sntech.de> - 2017-01-12 02:30 +0100
      Re: [PATCH v4 1/2] arm64: dts: rockchip: add "rockchip, grf" property  for RK3399 PMUCRU/CRU Xing Zheng <zhengxing@rock-chips.com> - 2017-01-11 02:10 +0100
        Re: [PATCH v4 1/2] arm64: dts: rockchip: add "rockchip, grf" property for RK3399 PMUCRU/CRU Heiko Stuebner <heiko@sntech.de> - 2017-01-11 02:20 +0100
          Re: [PATCH v4 1/2] arm64: dts: rockchip: add "rockchip, grf" property  for RK3399 PMUCRU/CRU Xing Zheng <zhengxing@rock-chips.com> - 2017-01-11 03:10 +0100
  [PATCH v4 2/2] dt-bindings: clk: add rockchip,grf property for RK3399 Xing Zheng <zhengxing@rock-chips.com> - 2017-01-10 07:20 +0100
    Re: [PATCH v4 2/2] dt-bindings: clk: add rockchip,grf property for RK3399 Doug Anderson <dianders@google.com> - 2017-01-10 19:40 +0100
    Re: [PATCH v4 2/2] dt-bindings: clk: add rockchip,grf property for  RK3399 Rob Herring <robh@kernel.org> - 2017-01-13 17:50 +0100
  Re: [PATCH v4 0/2] Add support rockchip,grf property for RK3399 PMU/GRU Heiko Stuebner <heiko@sntech.de> - 2017-01-13 20:20 +0100

csiph-web