Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1555688

Re: [PATCH] checkpatch: don't warn on every struct without const_structs file

From Johannes Berg <johannes@sipsolutions.net>
Newsgroups linux.kernel
Subject Re: [PATCH] checkpatch: don't warn on every struct without const_structs file
Date 2017-01-10 17:40 +0100
Message-ID <sY7CP-3Fl-43@gated-at.bofh.it> (permalink)
References <sY5hD-2jO-33@gated-at.bofh.it> <sY6dI-2W2-61@gated-at.bofh.it> <sY6dI-2W2-63@gated-at.bofh.it> <sY7t9-3Cj-35@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

> > I copied checkpatch elsewhere and ran it.
> 
> Why do you want to copy checkpatch "someplace else"?
> Instead of copy, I think you should soft link it.

Well, no, I have to distribute it with that.

> > Regardless, the current code is utterly stupid - it prints a
> > warning that it won't flag any structs, and then proceeds to flag
> > all structs.
> > 
> > If you must, send a patch to abort() [whatever the perl equivalent
> > is] when the file can't be found, but as it is, the code is just
> > idiotic.
> 
> Maybe so.
> 
> As is, your patch description is incomplete because
> it doesn't mention your use case.

I don't think that's relevant. The script is internally inconsistent,
as I do mention in the commit log, which is worth fixing.

johannes

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] checkpatch: don't warn on every struct without const_structs file Johannes Berg <johannes@sipsolutions.net> - 2017-01-10 15:10 +0100
  Re: [PATCH] checkpatch: don't warn on every struct without  const_structs file Joe Perches <joe@perches.com> - 2017-01-10 16:10 +0100
    Re: [PATCH] checkpatch: don't warn on every struct without  const_structs file Johannes Berg <johannes@sipsolutions.net> - 2017-01-10 16:10 +0100
      Re: [PATCH] checkpatch: don't warn on every struct without  const_structs file Joe Perches <joe@perches.com> - 2017-01-10 17:30 +0100
        Re: [PATCH] checkpatch: don't warn on every struct without  const_structs file Johannes Berg <johannes@sipsolutions.net> - 2017-01-10 17:40 +0100
          Re: [PATCH] checkpatch: don't warn on every struct without  const_structs file Joe Perches <joe@perches.com> - 2017-01-10 18:00 +0100

csiph-web