Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1555538

[RESEND PATCH v14 2/2] drm/i915: Put "cooked" vlank counters in frame CRC lines

Show all headers | View raw

Use drm_accurate_vblank_count so we have the full 32 bit to represent
the frame counter and userspace has a simpler way of knowing when the
counter wraps around.

Signed-off-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
Reviewed-by: Emil Velikov <emil.velikov@collabora.com>
Reviewed-by: Robert Foss <robert.foss@collabora.com>
---

 drivers/gpu/drm/i915/i915_irq.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c
index b9beb5955dae..75fb1f66cc0c 100644
--- a/drivers/gpu/drm/i915/i915_irq.c
+++ b/drivers/gpu/drm/i915/i915_irq.c
@@ -1557,7 +1557,6 @@ static void display_pipe_crc_irq_handler(struct drm_i915_private *dev_priv,
 	struct drm_driver *driver = dev_priv->drm.driver;
 	uint32_t crcs[5];
 	int head, tail;
-	u32 frame;
 
 	spin_lock(&pipe_crc->lock);
 	if (pipe_crc->source) {
@@ -1612,8 +1611,9 @@ static void display_pipe_crc_irq_handler(struct drm_i915_private *dev_priv,
 		crcs[2] = crc2;
 		crcs[3] = crc3;
 		crcs[4] = crc4;
-		frame = driver->get_vblank_counter(&dev_priv->drm, pipe);
-		drm_crtc_add_crc_entry(&crtc->base, true, frame, crcs);
+		drm_crtc_add_crc_entry(&crtc->base, true,
+				       drm_accurate_vblank_count(&crtc->base),
+				       crcs);
 	}
 }
 #else
-- 
2.9.3

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[RESEND PATCH v14 0/2] New debugfs API for capturing CRC of frames Tomeu Vizoso <tomeu.vizoso@collabora.com> - 2017-01-10 16:00 +0100
  [RESEND PATCH v14 2/2] drm/i915: Put "cooked" vlank counters in frame CRC lines Tomeu Vizoso <tomeu.vizoso@collabora.com> - 2017-01-10 16:00 +0100
    Re: [RESEND PATCH v14 2/2] drm/i915: Put "cooked" vlank counters in  frame CRC lines Ville Syrjälä <ville.syrjala@linux.intel.com> - 2017-01-10 17:00 +0100
      Re: [Intel-gfx] [RESEND PATCH v14 2/2] drm/i915: Put "cooked" vlank  counters in frame CRC lines Daniel Vetter <daniel@ffwll.ch> - 2017-01-10 17:40 +0100
        Re: [Intel-gfx] [RESEND PATCH v14 2/2] drm/i915: Put "cooked" vlank  counters in frame CRC lines Tomeu Vizoso <tomeu.vizoso@collabora.com> - 2017-01-16 10:20 +0100

csiph-web