Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1555166
| From | Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] usb: dwc3-exynos fix unspecified suspend clk error handling |
| Date | 2017-01-10 12:30 +0100 |
| Message-ID | <sY2MN-Gw-3@gated-at.bofh.it> (permalink) |
| References | <sXUmd-3ID-13@gated-at.bofh.it> |
| Organization | Cogent Embedded |
Hello!
On 01/10/2017 05:21 AM, Shuah Khan wrote:
> Fix dwc3_exynos_probe() to call clk_prepare_enable() only when suspend
> clock is specified. Call clk_disable_unprepare() from remove and probe
> error path only when susp_clk has been set from remove and probe error
> paths.
>
> Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
> ---
> drivers/usb/dwc3/dwc3-exynos.c | 10 ++++++----
> 1 file changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/usb/dwc3/dwc3-exynos.c b/drivers/usb/dwc3/dwc3-exynos.c
> index e27899b..f97a3d7 100644
> --- a/drivers/usb/dwc3/dwc3-exynos.c
> +++ b/drivers/usb/dwc3/dwc3-exynos.c
> @@ -131,8 +131,8 @@ static int dwc3_exynos_probe(struct platform_device *pdev)
> if (IS_ERR(exynos->susp_clk)) {
> dev_info(dev, "no suspend clk specified\n");
> exynos->susp_clk = NULL;
> - }
> - clk_prepare_enable(exynos->susp_clk);
> + } else
> + clk_prepare_enable(exynos->susp_clk);
CodingStyle: need {} here as well since another branch has them.
[...]
MBR, Sergei
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] usb: dwc3-exynos fix unspecified suspend clk error handling Shuah Khan <shuahkh@osg.samsung.com> - 2017-01-10 03:30 +0100
Re: [PATCH] usb: dwc3-exynos fix unspecified suspend clk error handling Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2017-01-10 12:30 +0100
Re: [PATCH] usb: dwc3-exynos fix unspecified suspend clk error handling Shuah Khan <shuahkh@osg.samsung.com> - 2017-01-10 15:40 +0100
Re: [PATCH] usb: dwc3-exynos fix unspecified suspend clk error handling Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> - 2017-01-10 13:10 +0100
Re: [PATCH] usb: dwc3-exynos fix unspecified suspend clk error handling Shuah Khan <shuahkh@osg.samsung.com> - 2017-01-10 15:20 +0100
Re: [PATCH] usb: dwc3-exynos fix unspecified suspend clk error handling Shuah Khan <shuahkh@osg.samsung.com> - 2017-01-10 15:40 +0100
Re: [PATCH] usb: dwc3-exynos fix unspecified suspend clk error handling Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> - 2017-01-10 17:10 +0100
Re: [PATCH] usb: dwc3-exynos fix unspecified suspend clk error handling Shuah Khan <shuahkh@osg.samsung.com> - 2017-01-10 17:30 +0100
Re: [PATCH] usb: dwc3-exynos fix unspecified suspend clk error handling Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> - 2017-01-10 18:10 +0100
Re: [PATCH] usb: dwc3-exynos fix unspecified suspend clk error handling vivek.gautam@codeaurora.org - 2017-01-10 18:50 +0100
Re: [PATCH] usb: dwc3-exynos fix unspecified suspend clk error handling Krzysztof Kozlowski <krzk@kernel.org> - 2017-01-10 19:30 +0100
Re: [PATCH] usb: dwc3-exynos fix unspecified suspend clk error handling "pankaj.dubey" <pankaj.dubey@samsung.com> - 2017-01-11 03:50 +0100
Re: [PATCH] usb: dwc3-exynos fix unspecified suspend clk error handling Anand Moon <linux.amoon@gmail.com> - 2017-01-10 19:00 +0100
Re: [PATCH] usb: dwc3-exynos fix unspecified suspend clk error handling Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> - 2017-01-10 19:10 +0100
Re: [PATCH] usb: dwc3-exynos fix unspecified suspend clk error handling Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> - 2017-01-10 19:30 +0100
Re: [PATCH] usb: dwc3-exynos fix unspecified suspend clk error handling Shuah Khan <shuahkh@osg.samsung.com> - 2017-01-10 19:40 +0100
Re: [PATCH] usb: dwc3-exynos fix unspecified suspend clk error handling Krzysztof Kozlowski <krzk@kernel.org> - 2017-01-10 20:10 +0100
Re: [PATCH] usb: dwc3-exynos fix unspecified suspend clk error handling Shuah Khan <shuahkh@osg.samsung.com> - 2017-01-10 20:30 +0100
Re: [PATCH] usb: dwc3-exynos fix unspecified suspend clk error handling Anand Moon <linux.amoon@gmail.com> - 2017-01-10 19:40 +0100
csiph-web