Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1553982

Re: [PATCH] spi: spi-axi: Free resources on error path

Show all headers | View raw

On 01/09/2017 01:02 AM, Christophe JAILLET wrote:
> We should go to 'err_put_master' here instead of returning directly.
> Otherwise a call to 'spi_master_put' is missing.
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>

Thanks.

Acked-by: Lars-Peter Clausen <lars@metafoo.de>

> ---
>  drivers/spi/spi-axi-spi-engine.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/spi/spi-axi-spi-engine.c b/drivers/spi/spi-axi-spi-engine.c
> index 319225d7e761..6ab4c7700228 100644
> --- a/drivers/spi/spi-axi-spi-engine.c
> +++ b/drivers/spi/spi-axi-spi-engine.c
> @@ -494,7 +494,8 @@ static int spi_engine_probe(struct platform_device *pdev)
>  			SPI_ENGINE_VERSION_MAJOR(version),
>  			SPI_ENGINE_VERSION_MINOR(version),
>  			SPI_ENGINE_VERSION_PATCH(version));
> -		return -ENODEV;
> +		ret = -ENODEV;
> +		goto err_put_master;
>  	}
>  
>  	spi_engine->clk = devm_clk_get(&pdev->dev, "s_axi_aclk");
> 

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] spi: spi-axi: Free resources on error path Christophe JAILLET <christophe.jaillet@wanadoo.fr> - 2017-01-09 01:10 +0100
  Re: [PATCH] spi: spi-axi: Free resources on error path Lars-Peter Clausen <lars@metafoo.de> - 2017-01-09 01:20 +0100
  Applied "spi: spi-axi: Free resources on error path" to the spi tree Mark Brown <broonie@kernel.org> - 2017-01-09 21:10 +0100

csiph-web