Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1553921

Re: [PATCH 03/11] perf, tools: Add support for parsing uncore json files

Path csiph.com!1.us.feeder.erje.net!2.us.feeder.erje.net!feeder.erje.net!2.eu.feeder.erje.net!news2.arglkargh.de!news.mixmin.net!news.unit0.net!news.panservice.it!bofh.it!news.nic.it!robomod
From Jiri Olsa <jolsa@redhat.com>
Newsgroups linux.kernel
Subject Re: [PATCH 03/11] perf, tools: Add support for parsing uncore json files
Date Sun, 08 Jan 2017 20:00:01 +0100
Message-ID <sXqRb-1KB-9@gated-at.bofh.it> (permalink)
References <sVySR-85Q-27@gated-at.bofh.it> <sVySR-85Q-25@gated-at.bofh.it>
X-Original-To Andi Kleen <andi@firstfloor.org>
MIME-Version 1.0
Content-Type text/plain; charset=us-ascii
Content-Disposition inline
User-Agent Mutt/1.7.1 (2016-10-04)
X-Scanned-By MIMEDefang 2.68 on 10.5.11.26
X-Greylist Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Sun, 08 Jan 2017 18:58:03 +0000 (UTC)
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 20
Organization linux.* mail to news gateway
X-Original-Cc acme@kernel.org, jolsa@kernel.org, linux-kernel@vger.kernel.org, mingo@kernel.org, Andi Kleen <ak@linux.intel.com>
X-Original-Date Sun, 8 Jan 2017 19:58:00 +0100
X-Original-Message-ID <20170108185800.GD14072@krava>
X-Original-References <20170103150833.6694-1-andi@firstfloor.org> <20170103150833.6694-4-andi@firstfloor.org>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1553921

Show key headers only | View raw


On Tue, Jan 03, 2017 at 07:08:25AM -0800, Andi Kleen wrote:

SNIP

>  /*
> diff --git a/tools/perf/util/pmu.c b/tools/perf/util/pmu.c
> index 29c254dd7380..8bffe99d8e3f 100644
> --- a/tools/perf/util/pmu.c
> +++ b/tools/perf/util/pmu.c
> @@ -229,11 +229,13 @@ static int perf_pmu__parse_snapshot(struct perf_pmu_alias *alias,
>  }
>  
>  static int __perf_pmu__new_alias(struct list_head *list, char *dir, char *name,
> -				 char *desc, char *val, char *long_desc,
> -				 char *topic)
> +				 char *desc __maybe_unused, char *val,

no need for 'desc' to be __maybe_unused

jirka

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread


Thread

Re: [PATCH 03/11] perf, tools: Add support for parsing uncore json  files Jiri Olsa <jolsa@redhat.com> - 2017-01-08 20:00 +0100
  Re: [PATCH 03/11] perf, tools: Add support for parsing uncore json  files Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-01-12 14:40 +0100

csiph-web