Re: [PATCH] tmpfs: clear S_ISGID when setting posix ACLs

From	Al Viro <viro@ZenIV.linux.org.uk>
Newsgroups	linux.kernel
Subject	Re: [PATCH] tmpfs: clear S_ISGID when setting posix ACLs
Date	2017-01-10 09:20 +0100
Message-ID	<sXZOW-7lr-3@gated-at.bofh.it> (permalink)
References	<sXx6h-5TA-3@gated-at.bofh.it> <sXZFf-7ig-27@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Jan 10, 2017 at 09:03:01AM +0100, Jan Kara wrote:
> On Mon 09-01-17 09:34:48, Gu Zheng wrote:
> > This change was missed the tmpfs modification in In CVE-2016-7097
> > commit 073931017b49 ("posix_acl: Clear SGID bit when setting
> > file permissions")
> > It can test by xfstest generic/375, which failed to clear
> > setgid bit in the following test case on tmpfs:
> > 
> >   touch $testfile
> >   chown 100:100 $testfile
> >   chmod 2755 $testfile
> >   _runas -u 100 -g 101 -- setfacl -m u::rwx,g::rwx,o::rwx $testfile
> > 
> > Signed-off-by: Gu Zheng <guzheng1@huawei.com>
> 
> Thanks. The patch looks good. You can add:
> 
> Reviewed-by: Jan Kara <jack@suse.cz>
> 
> Al, will you please merge it? Thanks!

Already applied, actually...

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] tmpfs: clear S_ISGID when setting posix ACLs Gu Zheng <guzheng1@huawei.com> - 2017-01-09 02:40 +0100
  Re: [PATCH] tmpfs: clear S_ISGID when setting posix ACLs Jan Kara <jack@suse.cz> - 2017-01-10 09:10 +0100
    Re: [PATCH] tmpfs: clear S_ISGID when setting posix ACLs Al Viro <viro@ZenIV.linux.org.uk> - 2017-01-10 09:20 +0100

csiph-web