Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1554895

Re: [PATCH v3] arm64: dts: rockchip: add "rockchip, grf" property for RK3399 PMUCRU/CRU

Show all headers | View raw

Hi,

On Mon, Jan 9, 2017 at 5:27 PM, Xing Zheng <zhengxing@rock-chips.com> wrote:
> The structure rockchip_clk_provider needs to refer the GRF regmap
> in somewhere, if the CRU node has not "rockchip,grf" property,
> calling syscon_regmap_lookup_by_phandle will return an invalid GRF
> regmap, and the MUXGRF type clock will be not supported.
>
> Therefore, we need to add them.
>
> Signed-off-by: Xing Zheng <zhengxing@rock-chips.com>
> ---
>
> Changes in v3:
> - add optional roperty rockchip,grf in rockchip,rk3399-cru.txt
>
> Changes in v2:
> - referring pmugrf for PMUGRU
> - fix the typo "invaild" in COMMIT message
>
>  Documentation/devicetree/bindings/clock/rockchip,rk3399-cru.txt | 5 +++++
>  arch/arm64/boot/dts/rockchip/rk3399.dtsi                        | 2 ++

"dts" and bindings shouldn't change in the same patch since they go
through different trees.  This is why I said:

> This looks sane to me, but before you land it you need to first send
> up a (separate) patch that adjusts:
>       --------

AKA: you need a two patch series here.

Sometimes it's OK to include bindings together with code changes
(depends on the maintainer), but never with dts changes.

-Doug

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v3] arm64: dts: rockchip: add "rockchip, grf" property for RK3399 PMUCRU/CRU Xing Zheng <zhengxing@rock-chips.com> - 2017-01-10 02:30 +0100
  Re: [PATCH v3] arm64: dts: rockchip: add "rockchip, grf" property for  RK3399 PMUCRU/CRU Shawn Lin <shawn.lin@rock-chips.com> - 2017-01-10 03:40 +0100
  Re: [PATCH v3] arm64: dts: rockchip: add "rockchip, grf" property for  RK3399 PMUCRU/CRU Doug Anderson <dianders@google.com> - 2017-01-10 04:10 +0100
  Re: [PATCH v3] arm64: dts: rockchip: add "rockchip, grf" property for  RK3399 PMUCRU/CRU Doug Anderson <dianders@google.com> - 2017-01-10 04:10 +0100
    Re: [PATCH v3] arm64: dts: rockchip: add "rockchip, grf" property for  RK3399 PMUCRU/CRU Xing Zheng <zhengxing@rock-chips.com> - 2017-01-10 04:40 +0100

csiph-web