Re: [PATCHv2 1/2] arm: Cleanup sanity_check_meminfo

From	Laura Abbott <labbott@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCHv2 1/2] arm: Cleanup sanity_check_meminfo
Date	2017-01-10 02:10 +0100
Message-ID	<sXT6N-306-17@gated-at.bofh.it> (permalink)
References	<sWpkt-1cs-7@gated-at.bofh.it> <sWpu9-1ii-7@gated-at.bofh.it> <sWuau-4AF-37@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 01/05/2017 08:17 PM, Nicolas Pitre wrote:
> On Thu, 5 Jan 2017, Laura Abbott wrote:
> 
>>
>> The logic for sanity_check_meminfo has become difficult to
>> follow. Clean up the code so it's more obvious what the code
>> is actually trying to do. Additionally, meminfo is now removed
>> so rename the function to better describe it's purpose.
> 
> s/it's/its/
> 
>> Signed-off-by: Laura Abbott <lauraa@codeaurora.org>
>> Signed-off-by: Laura Abbott <labbott@redhat.com>
>> ---
>> v2: Fixed code so b9a019899f61 ("ARM: 8590/1: sanity_check_meminfo():
>> avoid overflow on vmalloc_limit") should stay fixed. The casting and assignment
>> still seem ugly.
> 
> Are you referring to the initial vmalloc_limit assignment?
> 

I was referring to the min_t with u64 that gets assigned to phys_addr_t.
for lowmem_limit

>> @@ -1172,43 +1170,19 @@ void __init sanity_check_meminfo(void)
>>  	for_each_memblock(memory, reg) {
>>  		phys_addr_t block_start = reg->base;
>>  		phys_addr_t block_end = reg->base + reg->size;
>> -		phys_addr_t size_limit = reg->size;
>>  
>> -		if (reg->base >= vmalloc_limit)
>> -			highmem = 1;
>> -		else
>> -			size_limit = vmalloc_limit - reg->base;
>>  
>> -
> [...]
> 
> This leaves a spurious empty line. One was already there before your 
> patch but this would be a good opportunity to remove it.
> 
> Other than that...
> 
> Reviewed-by: Nicolas Pitre <nico@linaro.org>
> 
> 
> Nicolas
> 

Thanks,
Laura

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCHv2 1/2] arm: Cleanup sanity_check_meminfo Laura Abbott <labbott@redhat.com> - 2017-01-06 00:20 +0100
  Re: [PATCHv2 1/2] arm: Cleanup sanity_check_meminfo Nicolas Pitre <nicolas.pitre@linaro.org> - 2017-01-06 05:20 +0100
    Re: [PATCHv2 1/2] arm: Cleanup sanity_check_meminfo Laura Abbott <labbott@redhat.com> - 2017-01-10 02:10 +0100

csiph-web