Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1554794

Re: [PATCH] serial: 8250_lpss: Unconditionally set PCI master for Quark

From Andy Shevchenko <andy.shevchenko@gmail.com>
Newsgroups linux.kernel
Subject Re: [PATCH] serial: 8250_lpss: Unconditionally set PCI master for Quark
Date 2017-01-10 00:30 +0100
Message-ID <sXRy2-203-29@gated-at.bofh.it> (permalink)
References <sW0Fs-1jk-41@gated-at.bofh.it> <sW3MZ-3wW-7@gated-at.bofh.it> <sWoeK-ic-25@gated-at.bofh.it> <sXLLY-6Yo-31@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Mon, Jan 9, 2017 at 7:11 PM, Jan Kiszka <jan.kiszka@siemens.com> wrote:
> On 2017-01-05 22:56, Andy Shevchenko wrote:
>> On Thu, Jan 5, 2017 at 1:56 AM, Andy Shevchenko
>> <andy.shevchenko@gmail.com> wrote:
>>
>> Ah, Jan, perhaps you would like to comment on this one as well
>> http://marc.info/?l=linux-serial&m=148334902916347&w=2
>> ?
>>
>
> http://marc.info/?l=linux-serial&m=148334905916354&w=2 enables MSI, but
> that's only for Denverton, and there it is unconditional. So this is ok.

I think there is potential issue, if DMA driver is not compiled or
probed (by whatever reason) we will have MSI enabled without bus
mastering.
And like you said for sake of not copying wrong pattern for new API,
would be good to move it.

-- 
With Best Regards,
Andy Shevchenko

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] serial: 8250_lpss: Unconditionally set PCI master for Quark Jan Kiszka <jan.kiszka@siemens.com> - 2017-01-04 21:50 +0100
  Re: [PATCH] serial: 8250_lpss: Unconditionally set PCI master for Quark Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-01-05 01:10 +0100
    Re: [PATCH] serial: 8250_lpss: Unconditionally set PCI master for Quark Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-01-05 23:00 +0100
      Re: [PATCH] serial: 8250_lpss: Unconditionally set PCI master for  Quark Jan Kiszka <jan.kiszka@siemens.com> - 2017-01-09 18:20 +0100
        Re: [PATCH] serial: 8250_lpss: Unconditionally set PCI master for Quark Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-01-10 00:30 +0100
          Re: [PATCH] serial: 8250_lpss: Unconditionally set PCI master for  Quark Jan Kiszka <jan.kiszka@siemens.com> - 2017-01-10 08:00 +0100
  Re: [PATCH] serial: 8250_lpss: Unconditionally set PCI master for Quark Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-01-05 23:00 +0100
    Re: [PATCH] serial: 8250_lpss: Unconditionally set PCI master for  Quark Jan Kiszka <jan.kiszka@siemens.com> - 2017-01-09 18:10 +0100
      Re: [PATCH] serial: 8250_lpss: Unconditionally set PCI master for  Quark Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-01-10 13:10 +0100

csiph-web