Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1554798

Re: [PATCH] ACPI / OSL: Fix rcu synchronization logic

Show all headers | View raw

On Mon, Jan 9, 2017 at 10:56 AM, Lv Zheng <lv.zheng@intel.com> wrote:
> The rcu synchronization logic is originally provided to protect
> apei_read()/apei_write() as in the APEI drivers, there is NMI event source
> requiring non spinlock based synchronization mechanism.
>
> After that, ACPI developers think FADT registers may also require same
> facility, so they moved the RCU stuffs to generic ACPI layer.
>
> So now non-task-context ACPI map lookup is only protected by RCU.
>
> This triggers problem as acpi_os_map_memory()/acpi_os_unmap_memory() can be
> used to map/unmap tables as long as to map/unmap ACPI registers. When it is
> used for the ACPI tables, the caller could invoke this very early. When it
> is invoked earlier than workqueue_init() and later than
> check_early_ioremp_leak(), invoking synchronize_rcu_expedited() can cause a
> kernel hang.
>
> Actually this facility is only used to protect non-task-context ACPI map
> lookup,

That doesn't sound quite right.

acpi_os_read/write_memory() use RCU-protected list lookups, so it's
not just non-task-context AFAICS.

> and such mappings are only introduced by
> acpi_os_map_generic_address(). So before it is invoked, there is no need to
> invoke synchronize_rcu_expedited().

That said it may be fine to start actually synchronize RCU after
acpi_os_map_generic_address() has been called for the first time.  I
need a better (or more detailed) explanation why it is fine, though.

Thanks,
Rafael

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] ACPI / OSL: Fix rcu synchronization logic Lv Zheng <lv.zheng@intel.com> - 2017-01-09 11:00 +0100
  Re: [PATCH] ACPI / OSL: Fix rcu synchronization logic Borislav Petkov <bp@alien8.de> - 2017-01-09 11:20 +0100
    RE: [PATCH] ACPI / OSL: Fix rcu synchronization logic "Zheng, Lv" <lv.zheng@intel.com> - 2017-01-10 02:00 +0100
  Re: [PATCH] ACPI / OSL: Fix rcu synchronization logic "Rafael J. Wysocki" <rafael@kernel.org> - 2017-01-10 00:40 +0100
    RE: [PATCH] ACPI / OSL: Fix rcu synchronization logic "Zheng, Lv" <lv.zheng@intel.com> - 2017-01-10 06:50 +0100

csiph-web