Re: [PATCH v7 1/3] gpio: exar: add gpio for exar cards

From	Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v7 1/3] gpio: exar: add gpio for exar cards
Date	2017-01-09 22:20 +0100
Message-ID	<sXPwd-PW-7@gated-at.bofh.it> (permalink)
References	<sX93X-71t-3@gated-at.bofh.it> <sX93X-71t-25@gated-at.bofh.it> <sXFwR-30l-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Monday 09 January 2017 10:35 AM, Linus Walleij wrote:
> On Sun, Jan 8, 2017 at 12:57 AM, Sudip Mukherjee
> <sudipm.mukherjee@gmail.com> wrote:
>
>> Exar XR17V352/354/358 chips have 16 multi-purpose inputs/outputs which
>> can be controlled using gpio interface.
>>
>> Add the gpio specific code.
>>
>> Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
>
> Will I be able to merge this independently to the GPIO trees
> once we are done with review? (Looks like so...)

Yes, there should not be any dependency on the tty.

>
>> +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
>
> Is this really useful?

no, initially I used pr_*, but then that was converted to dev_*.

>
>> +#include <linux/device.h>
>> +#include <linux/gpio.h>
>
> No use:
> #include <linux/gpio/driver.h>
> ONLY
>
>> +static LIST_HEAD(exar_list);
>> +static DEFINE_MUTEX(exar_list_mtx);
>> +DEFINE_IDA(ida_index);
>
> What is this? A local list? I can understand the IDA index but in
> general, follow the state container pattern instead:
> Documentation/driver-model/design-patterns.txt

The local list is not doing anything now, after I have moved to using 
ida. But I will need the ida_index here to have the device number incase 
of multiple devices.

regards
sudip

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v7 0/3] add gpio support to exar Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2017-01-08 01:00 +0100
  [PATCH v7 3/3] serial: 8250_pci: remove exar code Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2017-01-08 01:00 +0100
  [PATCH v7 1/3] gpio: exar: add gpio for exar cards Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2017-01-08 01:00 +0100
    Re: [PATCH v7 1/3] gpio: exar: add gpio for exar cards Linus Walleij <linus.walleij@linaro.org> - 2017-01-09 11:40 +0100
      Re: [PATCH v7 1/3] gpio: exar: add gpio for exar cards Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2017-01-09 22:20 +0100

csiph-web