Re: [PATCH] direct-io: don't introduce another read of inode->i_blkbits

From	Jens Axboe <axboe@kernel.dk>
Newsgroups	linux.kernel
Subject	Re: [PATCH] direct-io: don't introduce another read of inode->i_blkbits
Date	2017-01-09 22:50 +0100
Message-ID	<sXPZf-ZK-5@gated-at.bofh.it> (permalink)
References	<sXmXf-7DZ-5@gated-at.bofh.it> <sXPZf-ZK-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 01/09/2017 02:42 PM, Jeff Moyer wrote:
> Commit 20ce44d545844 ("do_direct_IO: Use inode->i_blkbits to compute
> block count to be cleaned") introduced a regression: if the block size
> of the block device is changed while a direct I/O request is being
> setup, it can result in a panic.  See commit ab73857e354ab ("direct-io:
> don't read inode->i_blkbits multiple times") for the reasoning, and
> commit b87570f5d3496 ("Fix a crash when block device is read and block
> size is changed at the same time") for a more detailed problem
> description and reproducer.
> 
> Fixes: 20ce44d545844
> Signed-off-by: Jeff Moyer <jmoyer@redhat.com>
> 
> ---
> Chandan, can you please test this to ensure this still fixes your problem?

Please, that would be great. And if so, then let's fold the two.

-- 
Jens Axboe

Thread

[PATCH] do_direct_IO: Use inode->i_blkbits to compute block count to be cleaned Chandan Rajendra <chandan@linux.vnet.ibm.com> - 2017-01-08 15:50 +0100
  Re: [PATCH] do_direct_IO: Use inode->i_blkbits to compute block  count to be cleaned Christoph Hellwig <hch@infradead.org> - 2017-01-09 15:00 +0100
  Re: [PATCH] do_direct_IO: Use inode->i_blkbits to compute block count  to be cleaned Jens Axboe <axboe@kernel.dk> - 2017-01-09 16:40 +0100
  Re: [PATCH] do_direct_IO: Use inode->i_blkbits to compute block count to be cleaned Jeff Moyer <jmoyer@redhat.com> - 2017-01-09 17:10 +0100
  Re: [PATCH] do_direct_IO: Use inode->i_blkbits to compute block  count to be cleaned Jan Kara <jack@suse.cz> - 2017-01-09 21:30 +0100
  Re: [PATCH] direct-io: don't introduce another read of  inode->i_blkbits Jens Axboe <axboe@kernel.dk> - 2017-01-09 22:50 +0100
  [PATCH] direct-io: don't introduce another read of inode->i_blkbits Jeff Moyer <jmoyer@redhat.com> - 2017-01-09 22:50 +0100
    Re: [PATCH] direct-io: don't introduce another read of inode->i_blkbits Chandan Rajendra <chandan@linux.vnet.ibm.com> - 2017-01-10 06:30 +0100
      Re: [PATCH] direct-io: don't introduce another read of  inode->i_blkbits Jens Axboe <axboe@kernel.dk> - 2017-01-10 21:40 +0100

csiph-web