Re: [PATCH 2/2] nvme: improve cmb sysfs reporting

From	"Stephen Bates" <sbates@raithlin.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/2] nvme: improve cmb sysfs reporting
Date	2017-01-09 21:10 +0100
Message-ID	<sXOqu-dj-19@gated-at.bofh.it> (permalink)
References	<sP6mB-7Nv-9@gated-at.bofh.it> <sP6mB-7Nv-7@gated-at.bofh.it> <sQ8mq-1lk-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

> Minor nit below
>
>
>> +
>> +	for (i = NVME_CMB_CAP_SQS; i <= NVME_CMB_CAP_WDS; i++)
>>
> I'd prefer seeing (i = 0; i < ARRAY_SIZE(..); i++) because it provides
> automatic bounds checking against future code.
>

Thanks Jon, I will take a look at doing this in a V1.

Stephen

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH 2/2] nvme: improve cmb sysfs reporting "Stephen Bates" <sbates@raithlin.com> - 2017-01-09 21:10 +0100

csiph-web