Re: [PATCH net v2 5/5] net: qcom/emac: fix of_node and phydev leaks

From	Timur Tabi <timur@codeaurora.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH net v2 5/5] net: qcom/emac: fix of_node and phydev leaks
Date	2017-01-09 21:00 +0100
Message-ID	<sXOgO-8mt-23@gated-at.bofh.it> (permalink)
References	<sH6Wu-6po-7@gated-at.bofh.it> <sH6Wu-6po-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 11/24/2016 12:21 PM, Johan Hovold wrote:
> +	if (!has_acpi_companion(&pdev->dev))
> +		put_device(&adpt->phydev->mdio.dev);

I was wondering if, instead of calling put_device() only on non-ACPI systems, 
would it be better if on an ACPI system I called get_device() manually?  That 
is, some thing like this:

int emac_phy_config(struct platform_device *pdev, struct emac_adapter *adpt)
{
...
	if (has_acpi_companion(&pdev->dev)) {
...
		get_device(&mii_bus->dev);
	} else {
...

-- 
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm
Technologies, Inc.  Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH net v2 5/5] net: qcom/emac: fix of_node and phydev leaks Timur Tabi <timur@codeaurora.org> - 2017-01-09 21:00 +0100
  Re: [PATCH net v2 5/5] net: qcom/emac: fix of_node and phydev leaks Johan Hovold <johan@kernel.org> - 2017-01-10 09:50 +0100

csiph-web