Re: [PATCH] ibmvscsis: Fix srp_transfer_data fail return code

From	Greg KH <gregkh@linuxfoundation.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] ibmvscsis: Fix srp_transfer_data fail return code
Date	2017-01-09 19:00 +0100
Message-ID	<sXMoG-7ef-31@gated-at.bofh.it> (permalink)
References	<sXKZA-6rv-15@gated-at.bofh.it> <sXLiW-6zl-35@gated-at.bofh.it> <sXLVE-74k-21@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Jan 09, 2017 at 11:23:23AM -0600, Bryant G. Ly wrote:
> On 1/9/17 10:47 AM, Greg KH wrote:
> 
> > On Mon, Jan 09, 2017 at 10:21:20AM -0600, Bryant G. Ly wrote:
> > > From: "Bryant G. Ly" <bgly@us.ibm.com>
> > > 
> > > If srp_transfer_data fails within ibmvscsis_write_pending, then
> > > the most likely scenario is that the client timed out the op and
> > > removed the TCE mapping. Thus it will loop forever retrying the
> > > op that is pretty much guaranteed to fail forever. A better return
> > > code would be EIO instead of EAGAIN.
> > > 
> > > Cc: stable@vger.kernel.org
> > > Reported-by: Steven Royer <seroyer@linux.vnet.ibm.com>
> > > Tested-by: Steven Royer <seroyer@linux.vnet.ibm.com>
> > > Signed-off-by: Bryant G. Ly <bgly@us.ibm.com>
> > > ---
> > >   drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c | 2 +-
> > >   1 file changed, 1 insertion(+), 1 deletion(-)
> > Why are you sending this to me?
> > 
> > confused,
> > 
> > greg k-h
> Sorry I meant to put --to target-devel@vger.kernel.org, and just --cc you.

Why even cc: me?

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] ibmvscsis: Fix srp_transfer_data fail return code "Bryant G. Ly" <bryantly@linux.vnet.ibm.com> - 2017-01-09 17:30 +0100
  Re: [PATCH] ibmvscsis: Fix srp_transfer_data fail return code Greg KH <gregkh@linuxfoundation.org> - 2017-01-09 17:50 +0100
    Re: [PATCH] ibmvscsis: Fix srp_transfer_data fail return code "Bryant G. Ly" <bryantly@linux.vnet.ibm.com> - 2017-01-09 18:30 +0100
      Re: [PATCH] ibmvscsis: Fix srp_transfer_data fail return code Greg KH <gregkh@linuxfoundation.org> - 2017-01-09 19:00 +0100

csiph-web