Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1554547
| From | Florian Fainelli <f.fainelli@gmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH net-next v2] net: dsa: make "label" property optional for dsa2 |
| Date | 2017-01-09 18:50 +0100 |
| Message-ID | <sXMeZ-7b1-9@gated-at.bofh.it> (permalink) |
| References | (1 earlier) <sXCIG-19v-7@gated-at.bofh.it> <sXJK9-5LV-25@gated-at.bofh.it> <sXJTQ-5Pf-27@gated-at.bofh.it> <sXKmS-5Z0-19@gated-at.bofh.it> <sXKGe-6kS-3@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 01/09/2017 08:06 AM, Jiri Pirko wrote:
> Mon, Jan 09, 2017 at 04:45:33PM CET, vivien.didelot@savoirfairelinux.com wrote:
>> Hi Jiri,
>>
>> Jiri Pirko <jiri@resnulli.us> writes:
>>
>>>> Extra question: shouldn't phys_port_{id,name} be switchdev attributes in
>>>
>>> Again, phys_port_id has nothing to do with switches. Should be removed
>>> from dsa because its use there is incorrect.
>>
>> Florian, since 3a543ef just got in, can it be reverted?
>
> Yes, please revert it. It is only in net-next.
Maybe the use case can be understood before reverting the change. How do
we actually the physical port number of an Ethernet switch per-port
network device? The name is not enough, because there are plenty of
cases where we need to manipulate a physical port number (be it just for
informational purposes).
Should we just amend the existing description of ndo_get_phys_port_id()?
Should we introduce another ndo for that?
--
Florian
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH net-next v2] net: dsa: make "label" property optional for dsa2 Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-01-09 00:20 +0100
Re: [PATCH net-next v2] net: dsa: make "label" property optional for dsa2 Andrew Lunn <andrew@lunn.ch> - 2017-01-09 00:40 +0100
Re: [PATCH net-next v2] net: dsa: make "label" property optional for dsa2 Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-01-09 04:00 +0100
Re: [PATCH net-next v2] net: dsa: make "label" property optional for dsa2 Jiri Pirko <jiri@resnulli.us> - 2017-01-09 08:40 +0100
Re: [PATCH net-next v2] net: dsa: make "label" property optional for dsa2 Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-01-09 16:10 +0100
Re: [PATCH net-next v2] net: dsa: make "label" property optional for dsa2 Jiri Pirko <jiri@resnulli.us> - 2017-01-09 16:20 +0100
Re: [PATCH net-next v2] net: dsa: make "label" property optional for dsa2 Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-01-09 16:50 +0100
Re: [PATCH net-next v2] net: dsa: make "label" property optional for dsa2 Jiri Pirko <jiri@resnulli.us> - 2017-01-09 17:10 +0100
Re: [PATCH net-next v2] net: dsa: make "label" property optional for dsa2 Florian Fainelli <f.fainelli@gmail.com> - 2017-01-09 18:50 +0100
Re: [PATCH net-next v2] net: dsa: make "label" property optional for dsa2 Jiri Pirko <jiri@resnulli.us> - 2017-01-09 19:10 +0100
Re: [PATCH net-next v2] net: dsa: make "label" property optional for dsa2 Florian Fainelli <f.fainelli@gmail.com> - 2017-01-09 19:10 +0100
Re: [PATCH net-next v2] net: dsa: make "label" property optional for dsa2 Jiri Pirko <jiri@resnulli.us> - 2017-01-10 11:00 +0100
Re: [PATCH net-next v2] net: dsa: make "label" property optional for dsa2 Florian Fainelli <f.fainelli@gmail.com> - 2017-01-10 19:00 +0100
Re: [PATCH net-next v2] net: dsa: make "label" property optional for dsa2 Jiri Pirko <jiri@resnulli.us> - 2017-01-11 08:30 +0100
Re: [PATCH net-next v2] net: dsa: make "label" property optional for dsa2 Jiri Pirko <jiri@resnulli.us> - 2017-01-09 17:10 +0100
Re: [PATCH net-next v2] net: dsa: make "label" property optional for dsa2 Andrew Lunn <andrew@lunn.ch> - 2017-01-09 17:10 +0100
csiph-web