Re: [PATCH 2/2] hwmon/tmp401: Fix some checkstyle warnings

From	Guenter Roeck <linux@roeck-us.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/2] hwmon/tmp401: Fix some checkstyle warnings
Date	2017-01-09 18:20 +0100
Message-ID	<sXLLY-6Yo-19@gated-at.bofh.it> (permalink)
References	<sXLCi-6V3-23@gated-at.bofh.it> <sXLCi-6V3-29@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Jan 09, 2017 at 05:47:38PM +0100, jeroen.de_wachter.ext@nokia.com wrote:
> From: Jeroen De Wachter <jeroen.de_wachter.ext@nokia.com>
> 
> Signed-off-by: Jeroen De Wachter <jeroen.de_wachter.ext@nokia.com>
> ---
>  drivers/hwmon/tmp401.c | 66 +++++++++++++++++++++++++-------------------------
>  1 file changed, 33 insertions(+), 33 deletions(-)
> 
> diff --git a/drivers/hwmon/tmp401.c b/drivers/hwmon/tmp401.c
> index 88b17e4..853056d 100644
> --- a/drivers/hwmon/tmp401.c
> +++ b/drivers/hwmon/tmp401.c
> @@ -498,40 +498,40 @@ static ssize_t set_update_interval(struct device *dev,
>  	return count;
>  }
>  
> -static SENSOR_DEVICE_ATTR_2(temp1_input, S_IRUGO, show_temp, NULL, 0, 0);
> -static SENSOR_DEVICE_ATTR_2(temp1_min, S_IWUSR | S_IRUGO, show_temp,
> +static SENSOR_DEVICE_ATTR_2(temp1_input, 0444, show_temp, NULL, 0, 0);
> +static SENSOR_DEVICE_ATTR_2(temp1_min, 0644, show_temp,

I hate this change :-(.

Please don't bother. I have a coccinelle driven series in the works which makes 
those changes automatically for all drivers (and, along the line, simplifies
the SENSOR_DEVICE_ATTR[_2] macros).

Thanks,
Guenter

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 2/2] hwmon/tmp401: Fix some checkstyle warnings <jeroen.de_wachter.ext@nokia.com> - 2017-01-09 18:10 +0100
  Re: [PATCH 2/2] hwmon/tmp401: Fix some checkstyle warnings Guenter Roeck <linux@roeck-us.net> - 2017-01-09 18:20 +0100

csiph-web