Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1554167
| From | Balbir Singh <bsingharora@gmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [HMM v15 01/16] mm/free_hot_cold_page: catch ZONE_DEVICE pages |
| Date | 2017-01-09 10:30 +0100 |
| Message-ID | <sXEr7-2m9-7@gated-at.bofh.it> (permalink) |
| References | <sWEWd-3VU-3@gated-at.bofh.it> <sWEWe-3VU-17@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Fri, Jan 06, 2017 at 11:46:28AM -0500, Jérôme Glisse wrote:
> Catch page from ZONE_DEVICE in free_hot_cold_page(). This should never
> happen as ZONE_DEVICE page must always have an elevated refcount.
>
> This is safety-net to catch any refcounting issues in a sane way for any
> ZONE_DEVICE pages.
>
> Signed-off-by: Jérôme Glisse <jglisse@redhat.com>
> Cc: Dan Williams <dan.j.williams@intel.com>
> Cc: Ross Zwisler <ross.zwisler@linux.intel.com>
> ---
> mm/page_alloc.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> index 1c24112..355beb4 100644
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -2445,6 +2445,16 @@ void free_hot_cold_page(struct page *page, bool cold)
> unsigned long pfn = page_to_pfn(page);
> int migratetype;
>
> + /*
> + * This should never happen ! Page from ZONE_DEVICE always must have an
> + * active refcount. Complain about it and try to restore the refcount.
> + */
> + if (is_zone_device_page(page)) {
> + VM_BUG_ON_PAGE(is_zone_device_page(page), page);
This can be VM_BUG_ON_PAGE(1, page), hopefully the compiler does the right thing
here. I suspect this should be a BUG_ON, independent of CONFIG_DEBUG_VM
> + page_ref_inc(page);
> + return;
> + }
> +
Balbir Singh.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[HMM v15 01/16] mm/free_hot_cold_page: catch ZONE_DEVICE pages Jérôme Glisse <jglisse@redhat.com> - 2017-01-06 16:50 +0100
Re: [HMM v15 01/16] mm/free_hot_cold_page: catch ZONE_DEVICE pages Balbir Singh <bsingharora@gmail.com> - 2017-01-09 10:30 +0100
Re: [HMM v15 01/16] mm/free_hot_cold_page: catch ZONE_DEVICE pages Dave Hansen <dave.hansen@intel.com> - 2017-01-09 17:30 +0100
Re: [HMM v15 01/16] mm/free_hot_cold_page: catch ZONE_DEVICE pages Jerome Glisse <jglisse@redhat.com> - 2017-01-09 18:00 +0100
Re: [HMM v15 01/16] mm/free_hot_cold_page: catch ZONE_DEVICE pages Dave Hansen <dave.hansen@intel.com> - 2017-01-09 18:10 +0100
Re: [HMM v15 01/16] mm/free_hot_cold_page: catch ZONE_DEVICE pages Jerome Glisse <jglisse@redhat.com> - 2017-01-09 19:00 +0100
csiph-web