Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1554067

[RFC 48/55] KVM: arm64: Emulate TLBI instruction

Path csiph.com!goblin1!goblin2!goblin.stu.neva.ru!news.unit0.net!news.panservice.it!diesel.cu.mi.it!bofh.it!news.nic.it!robomod
From Jintack Lim <jintack@cs.columbia.edu>
Newsgroups linux.kernel
Subject [RFC 48/55] KVM: arm64: Emulate TLBI instruction
Date Mon, 09 Jan 2017 07:30:02 +0100
Message-ID <sXBCW-wl-33@gated-at.bofh.it> (permalink)
References <sXBCV-wl-3@gated-at.bofh.it>
X-Original-To christoffer.dall@linaro.org, marc.zyngier@arm.com, pbonzini@redhat.com, rkrcmar@redhat.com, linux@armlinux.org.uk, catalin.marinas@arm.com, will.deacon@arm.com, vladimir.murzin@arm.com, suzuki.poulose@arm.com, mark.rutland@arm.com, james.morse@arm.com, lorenzo.pieralisi@arm.com, kevin.brodsky@arm.com, wcohen@redhat.com, shankerd@codeaurora.org, geoff@infradead.org, andre.przywara@arm.com, eric.auger@redhat.com, anna-maria@linutronix.de, shihwei@cs.columbia.edu, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, linux-kernel@vger.kernel.org
X-Google-Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=HgoeRbscYA5QdpEOsNpIhgRmeOCICYzHfcarNNNUqJI=; b=o9MnkdRvAtaqW3QKefm/SakROisNwh8cQ0all6laEP1jIYRyTLhMkklBHmJsUVcrm6 omJwReKKEcctHbbE+bF7N+6OtiytJgizO6+LK9ggTUFtNPMRghgEwS3ZJm1QEfMBhhtx uluEDzJ+I4t9E2jvUwG1RH4d/JOa9mXCntqqaomffDPcgKHyLWAwHBpGSMXv5eDzGYuM fIiPPoABndcjzp2ci7qe86iardLCgFSvB0rdBBj7MllyJUOGfvuuF/Gg4ri/I5Wao2xD TftBcQswR4T5M4wK7Uc4Bbj9kMuSB+rG0j4PKBUxzvE6m2umPQ4Gq9CWZmf1BB+ldFyd B5/A==
X-Gm-Message-State AIkVDXKsHmOCX7VBVhhKWNloqQrpfP5N9BAykrOYtMSrGnBqAaQ9gsGszYBXYhjvspQ8uFEc2Rq+32ioRSFD8nXmpE4HUTPU6qziMfX7vHCezo/NYv6g7c+OGIwrgYNJPnVb9nsuMYwbhto32VrgkGlerOU=
X-Received by 10.55.127.129 with SMTP id a123mr83632580qkd.129.1483943192148; Sun, 08 Jan 2017 22:26:32 -0800 (PST)
X-Received by 10.55.127.129 with SMTP id a123mr83632575qkd.129.1483943192019; Sun, 08 Jan 2017 22:26:32 -0800 (PST)
X-Mailer git-send-email 1.9.1
X-No-Spam-Score Local
X-Scanned-By MIMEDefang 2.78 on 128.59.72.16
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 36
Organization linux.* mail to news gateway
X-Original-Cc jintack@cs.columbia.edu
X-Original-Date Mon, 9 Jan 2017 01:24:44 -0500
X-Original-Message-ID <1483943091-1364-49-git-send-email-jintack@cs.columbia.edu>
X-Original-References <1483943091-1364-1-git-send-email-jintack@cs.columbia.edu>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1554067

Show key headers only | View raw


From: Christoffer Dall <christoffer.dall@linaro.org>

Currently, we flush ALL shadow stage-2 page tables on the tlbi
instruction execution. We may be able to do this more efficiently by
considering the vttbr_el2 value of the guest hypervisor, but leave it
for now.

Signed-off-by: Christoffer Dall <christoffer.dall@linaro.org>
Signed-off-by: Jintack Lim <jintack@cs.columbia.edu>
---
 arch/arm64/kvm/sys_regs.c | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/kvm/sys_regs.c b/arch/arm64/kvm/sys_regs.c
index ddb641c..b0a057d 100644
--- a/arch/arm64/kvm/sys_regs.c
+++ b/arch/arm64/kvm/sys_regs.c
@@ -2013,8 +2013,14 @@ static int emulate_sys_reg(struct kvm_vcpu *vcpu,
 static int emulate_tlbi(struct kvm_vcpu *vcpu,
 			     struct sys_reg_params *params)
 {
-	/* TODO: support tlbi instruction emulation*/
-	kvm_inject_undefined(vcpu);
+	/*
+	 * We unmap ALL stage-2 page tables on tlbi instruction.
+	 * We may make it more efficient by looking at the exact tlbi
+	 * instruction.
+	 */
+	stage2_unmap_vm(vcpu->kvm);
+	kvm_nested_s2_unmap(vcpu);
+
 	return 1;
 }
 
-- 
1.9.1

Back to linux.kernel | Previous | Next | Find similar | Unroll thread


Thread

[RFC 48/55] KVM: arm64: Emulate TLBI instruction Jintack Lim <jintack@cs.columbia.edu> - 2017-01-09 07:30 +0100

csiph-web