Re: [PATCH net-next 1/2] net: dsa: make "label" property optional for dsa2

From	Uwe Kleine-König <uwe@kleine-koenig.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH net-next 1/2] net: dsa: make "label" property optional for dsa2
Date	2017-01-07 21:50 +0100
Message-ID	<sX665-5bV-7@gated-at.bofh.it> (permalink)
References	<sWLbk-8oT-19@gated-at.bofh.it> <sWLbk-8oT-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Hello,

On 01/06/2017 11:00 PM, Vivien Didelot wrote:
> In the new DTS bindings for DSA (dsa2), the "ethernet" and "link"
> phandles are respectively mandatory and exclusive to CPU port and DSA
> link device tree nodes.
> 
> Simplify dsa2.c a bit by checking the presence of such phandle instead
> of checking the redundant "label" property.
> 
> Then the Linux philosophy for Ethernet switch ports is to expose them to
> userspace as standard NICs by default. Thus use the standard enumerated
> "eth%d" device name if no "label" property is provided for a user port.
> This allows to save DTS files from subjective net device names.
> 
> If one wants to rename an interface, udev rules can be used as usual.
> The sysfs phys_port_id and phys_switch_id also provide physical data.
> 
> Of course the current behavior is unchanged, and the optional "label"
> property for user ports has precedence over the enumerated name.
> 
> Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Acked-by: Uwe Kleine-König <uwe@kleine-koenig.org>

Thanks
Uwe

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH net-next 1/2] net: dsa: make "label" property optional for dsa2 Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-01-06 23:30 +0100
  Re: [PATCH net-next 1/2] net: dsa: make "label" property optional  for dsa2 Andrew Lunn <andrew@lunn.ch> - 2017-01-06 23:30 +0100
    Re: [PATCH net-next 1/2] net: dsa: make "label" property optional for  dsa2 Florian Fainelli <f.fainelli@gmail.com> - 2017-01-06 23:50 +0100
      Re: [PATCH net-next 1/2] net: dsa: make "label" property optional for  dsa2 Uwe Kleine-König <uwe@kleine-koenig.org> - 2017-01-07 21:40 +0100
  Re: [PATCH net-next 1/2] net: dsa: make "label" property optional for  dsa2 Uwe Kleine-König <uwe@kleine-koenig.org> - 2017-01-07 21:50 +0100

csiph-web