Re: [PATCH v3 2/5] arm64: dts: exynos: make tm2 and tm2e independent from each other

From	Andi Shyti <andi.shyti@samsung.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 2/5] arm64: dts: exynos: make tm2 and tm2e independent from each other
Date	2017-01-06 10:30 +0100
Message-ID	<sWz0u-8bL-25@gated-at.bofh.it> (permalink)
References	(1 earlier) <sWu0N-4uM-29@gated-at.bofh.it> <sWu0N-4uM-27@gated-at.bofh.it> <sWwP0-6sj-21@gated-at.bofh.it> <sWxBn-6Us-1@gated-at.bofh.it> <sWye6-7zH-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Krzysztof,

> > > >  .../boot/dts/exynos/exynos5433-tm2-common.dtsi     | 1118 +++++++++++++++++++
> > > >  arch/arm64/boot/dts/exynos/exynos5433-tm2.dts      | 1153 +-------------------
> > > 
> > > Like talking to a wall. Without any feedback. If my instructions were
> > > wrong (and it is not possible to detect rename) then please say it (you
> > > can add personal comments after separator ---).
> > 
> > no Krzysztof, I'm sorry, but this patch has been formatted with
> > the diff algorithm *you* asked, -B50% both version 2 (where you
> > didn't comment) and version 3. If you still don't like it, please
> > don't blame me, blame the algorithm.
> 
> If you wrote it in cover letter or after '---' I wouldn't complain
> because I would know that my feedback was ignored. But here it is like
> black hole - I do not know whether I was ignored or it was not working.

In the cover letter is written:

 "- patch 3 diff has been generated with -B50%"

in "Changes in v2:". In v3 patch 3 has become patch 2.

> > Now we can stay here at trying random diff algorithms (as they
> > give more or less the same result) or you tell me which exact
> > algorithm you want me to use. Besides, for me it's clear,
> > tm2-common is all new, while in tm2 you have on one side the '-'
> > (if it applies nothing has changed) on the bottom the '+'.
> 
> Maybe that depends on the git?
> $ git --version 
> git version 2.9.3
> $ git format-patch -2 -B50%
> ...
>   21  ...ynos5433-tm2.dts => exynos5433-tm2-common.dtsi} |   24 +-
>   22  arch/arm64/boot/dts/exynos/exynos5433-tm2.dts      | 1153 +-------------------
>   23  arch/arm64/boot/dts/exynos/exynos5433-tm2e.dts     |   22 +-
>   24  3 files changed, 56 insertions(+), 1143 deletions(-)
>   25  copy arch/arm64/boot/dts/exynos/{exynos5433-tm2.dts => exynos5433-tm2-common.dtsi} (98%)
>   26  rewrite arch/arm64/boot/dts/exynos/exynos5433-tm2.dts (98%)

I guess you're right, this has been generated from Jaechul's PC
who perhaps has a different version. I have version 2.11.0 and I
have same output as you.

I will send the patch generated from my PC as reply to your mail.

Andi

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v3 0/5] Add touch key driver support for TM2 Jaechul Lee <jcsing.lee@samsung.com> - 2017-01-06 05:10 +0100
  [PATCH v3 4/5] input: tm2-touchkey: Add touchkey driver support for TM2 Jaechul Lee <jcsing.lee@samsung.com> - 2017-01-06 05:10 +0100
  Re: [PATCH v3 2/5] arm64: dts: exynos: make tm2 and tm2e independent  from each other Andi Shyti <andi.shyti@samsung.com> - 2017-01-06 09:00 +0100
    Re: [PATCH v3 2/5] arm64: dts: exynos: make tm2 and tm2e independent  from each other Krzysztof Kozlowski <krzk@kernel.org> - 2017-01-06 09:40 +0100
      Re: [PATCH v3 2/5] arm64: dts: exynos: make tm2 and tm2e independent  from each other Andi Shyti <andi.shyti@samsung.com> - 2017-01-06 10:30 +0100

csiph-web