Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1552562

Re: [PATCH] iommu: Drop the of_iommu_{set/get}_ops() interface

Show all headers | View raw

On Wed, 2017-01-04 at 15:11 +0000, Robin Murphy wrote:
> [+Yong Wu for mtk_iommu]
> 
> On 03/01/17 17:34, Lorenzo Pieralisi wrote:
> > With the introduction of the new iommu_{register/get}_instance()
> > interface in commit e4f10ffe4c9b ("iommu: Make of_iommu_set/get_ops() DT
> > agnostic") (based on struct fwnode_handle as look-up token, so firmware
> > agnostic) to register IOMMU instances with the core IOMMU layer there is
> > no reason to keep the old OF based interface around any longer.
> > 
> > Convert all the IOMMU drivers (and OF IOMMU core code) that rely on the
> > of_iommu_{set/get}_ops() to the new kernel interface to register/retrieve
> > IOMMU instances and remove the of_iommu_{set/get}_ops() remaining glue
> > code in order to complete the interface rework.
> 
> Reviewed-by: Robin Murphy <robin.murphy@arm.com>
> 
> Looking at before-and-after disassemblies, of_iommu.o is binary
> identical, and exynos-iommu.o differs only in the use of dev->fwnode
> rather than &dev->of_node->fwnode (and is binary identical if I hack it
> back to the latter). I'm not sure why the (GCC 6.2) codegen for
> mtk_iommu.o changes quite so much when merely replacing a callsite with
> the contents of its static inline callee, but it does :/
> 
> Robin.
> 

For MTK IOMMU,

Tested-by: Yong Wu <yong.wu@mediatek.com>

Thanks.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] iommu: Drop the of_iommu_{set/get}_ops() interface Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> - 2017-01-03 18:40 +0100
  RE: [PATCH] iommu: Drop the of_iommu_{set/get}_ops() interface "Sricharan" <sricharan@codeaurora.org> - 2017-01-04 09:10 +0100
  Re: [PATCH] iommu: Drop the of_iommu_{set/get}_ops() interface Robin Murphy <robin.murphy@arm.com> - 2017-01-04 16:20 +0100
    Re: [PATCH] iommu: Drop the of_iommu_{set/get}_ops() interface Yong Wu <yong.wu@mediatek.com> - 2017-01-06 08:00 +0100
  Re: [PATCH] iommu: Drop the of_iommu_{set/get}_ops() interface Will Deacon <will.deacon@arm.com> - 2017-01-04 16:30 +0100
  Re: [PATCH] iommu: Drop the of_iommu_{set/get}_ops() interface Marek Szyprowski <m.szyprowski@samsung.com> - 2017-01-09 09:20 +0100

csiph-web