Re: [PATCH 17/22] power: supply: add battery driver for AXP20X and AXP22X PMICs

From	Sebastian Reichel <sre@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 17/22] power: supply: add battery driver for AXP20X and AXP22X PMICs
Date	2017-01-06 04:00 +0100
Message-ID	<sWsV4-3uq-13@gated-at.bofh.it> (permalink)
References	<sVdY5-1dY-17@gated-at.bofh.it> <sVer7-1K6-11@gated-at.bofh.it> <sWkb7-66L-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Hi,

On Thu, Jan 05, 2017 at 02:34:48PM -0300, Ezequiel Garcia wrote:
> > +static int axp20x_power_probe(struct platform_device *pdev)
> > +{
> > +       struct axp20x_dev *axp20x = dev_get_drvdata(pdev->dev.parent);
> > +       struct axp20x_batt_ps *axp20x_batt;
> > +       struct power_supply_config psy_cfg = {};
> > +
> 
> To be consistent with the AC power supply and USB power supply,
> you might want to call of_device_is_available() here.
> Otherwise, the device probes even if "disabled" in the DTS.

I would expect that check in the mfd code. Probe should not be
called at all if the sub-device is disabled.

-- Sebastian

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH 17/22] power: supply: add battery driver for AXP20X and  AXP22X PMICs Ezequiel Garcia <ezequiel@vanguardiasur.com.ar> - 2017-01-05 18:40 +0100
  Re: [PATCH 17/22] power: supply: add battery driver for AXP20X and  AXP22X PMICs Sebastian Reichel <sre@kernel.org> - 2017-01-06 04:00 +0100

csiph-web