Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1552470

Re: [PATCH v4 1/5] crash: move crashkernel parsing and vmcore related code under CONFIG_CRASH_CORE

Show all headers | View raw

Hi Hari

Thanks for the update.

On 01/05/17 at 10:59pm, Hari Bathini wrote:
> Traditionally, kdump is used to save vmcore in case of a crash. Some
> architectures like powerpc can save vmcore using architecture specific
> support instead of kexec/kdump mechanism. Such architecture specific
> support also needs to reserve memory, to be used by dump capture kernel.
> crashkernel parameter can be a reused, for memory reservation, by such
> architecture specific infrastructure.
> 
> But currently, code related to vmcoreinfo and parsing of crashkernel
> parameter is built under CONFIG_KEXEC_CORE. This patch introduces
> CONFIG_CRASH_CORE and moves the above mentioned code under this config,
> allowing code reuse without dependency on CONFIG_KEXEC. There is no
> functional change with this patch.
> 
> Signed-off-by: Hari Bathini <hbathini@linux.vnet.ibm.com>
> ---
> 
> Changes from v3:
> * Renamed log_buf_kexec_setup()to log_buf_vmcoreinfo_setup() instead of
>   log_buf_crash_setup().
> 
> Changes from v2:
> * Used CONFIG_CRASH_CORE instead of CONFIG_KEXEC_CORE at
>   appropriate places in printk and ksysfs.
> 
> 
>  arch/Kconfig               |    4 
>  include/linux/crash_core.h |   65 ++++++
>  include/linux/kexec.h      |   57 ------
>  include/linux/printk.h     |    4 
>  kernel/Makefile            |    1 
>  kernel/crash_core.c        |  445 ++++++++++++++++++++++++++++++++++++++++++++
>  kernel/kexec_core.c        |  404 ----------------------------------------
>  kernel/ksysfs.c            |    8 +
>  kernel/printk/printk.c     |    6 -
>  9 files changed, 531 insertions(+), 463 deletions(-)
>  create mode 100644 include/linux/crash_core.h
>  create mode 100644 kernel/crash_core.c
> 

[snip]

Acked-by: Dave Young <dyoung@redhat.com>

Thanks
Dave

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v4 0/5] kexec/fadump: remove dependency with CONFIG_KEXEC  and reuse crashkernel parameter for fadump Hari Bathini <hbathini@linux.vnet.ibm.com> - 2017-01-05 18:30 +0100
  [PATCH v4 5/5] powerpc/fadump: update documentation about  crashkernel parameter reuse Hari Bathini <hbathini@linux.vnet.ibm.com> - 2017-01-05 18:40 +0100
  [PATCH v4 2/5] ia64: reuse append_elf_note() and final_note()  functions Hari Bathini <hbathini@linux.vnet.ibm.com> - 2017-01-05 18:40 +0100
    Re: [PATCH v4 2/5] ia64: reuse append_elf_note() and final_note()  functions Dave Young <dyoung@redhat.com> - 2017-01-06 03:10 +0100
  [PATCH v4 1/5] crash: move crashkernel parsing and vmcore related  code under CONFIG_CRASH_CORE Hari Bathini <hbathini@linux.vnet.ibm.com> - 2017-01-05 18:40 +0100
    Re: [PATCH v4 1/5] crash: move crashkernel parsing and vmcore  related code under CONFIG_CRASH_CORE Dave Young <dyoung@redhat.com> - 2017-01-06 03:10 +0100
  [PATCH v4 3/5] powerpc/fadump: remove dependency with CONFIG_KEXEC Hari Bathini <hbathini@linux.vnet.ibm.com> - 2017-01-05 18:40 +0100
    Re: [PATCH v4 3/5] powerpc/fadump: remove dependency with  CONFIG_KEXEC Mahesh Jagannath Salgaonkar <mahesh@linux.vnet.ibm.com> - 2017-01-13 12:30 +0100
  [PATCH v4 4/5] powerpc/fadump: reuse crashkernel parameter for  fadump memory reservation Hari Bathini <hbathini@linux.vnet.ibm.com> - 2017-01-05 18:40 +0100
    Re: [PATCH v4 4/5] powerpc/fadump: reuse crashkernel parameter for  fadump memory reservation Mahesh Jagannath Salgaonkar <mahesh@linux.vnet.ibm.com> - 2017-01-13 13:00 +0100

csiph-web