Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1552427

Re: [PATCH] lib/vsprintf.c: remove %Z support

Show all headers | View raw

On Wed, 4 Jan 2017 02:01:27 +0300 Alexey Dobriyan <adobriyan@gmail.com> wrote:

> Now that %z is standartised in C99 there is no reason to support %Z.
> Unlike %L it doesn't even make format strings smaller.
> 
> Use BUILD_BUG_ON in a couple ATM drivers.
> 
> In case anyone didn't notice lib/vsprintf.o is about half of SLUB
> which is in my opinion is quite an achievement. Hopefully this patch
> inspires someone else to trim vsprintf.c more.

There's a risk that more %Z uses will sneak into the tree during the
4.10 development cycle, and possibly even later.  So I added a
note-to-self to re-grep the tree before sending this upstream, but that
won't prevent people adding new instances later on: code which was
tested under earlier kernels which has %Z support.

The best suggestion I have is to add a checkpatch rule to try to catch
new %Z's being added.

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] lib/vsprintf.c: remove %Z support Andrew Morton <akpm@linux-foundation.org> - 2017-01-06 01:40 +0100
  [PATCH] checkpatch.pl: warn against using %Z Alexey Dobriyan <adobriyan@gmail.com> - 2017-01-09 23:10 +0100
    Re: [PATCH] checkpatch.pl: warn against using %Z Joe Perches <joe@perches.com> - 2017-01-09 23:20 +0100

csiph-web