Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1552339

Re: [PATCH v4 07/11] pwm: imx: Provide atomic PWM support for i.MX PWMv2

From Andy Shevchenko <andy.shevchenko@gmail.com>
Newsgroups linux.kernel
Subject Re: [PATCH v4 07/11] pwm: imx: Provide atomic PWM support for i.MX PWMv2
Date 2017-01-05 22:30 +0100
Message-ID <sWnLH-83-3@gated-at.bofh.it> (permalink)
References <sW3jX-37n-3@gated-at.bofh.it> <sW3jX-37n-37@gated-at.bofh.it> <sWc3U-pg-21@gated-at.bofh.it> <sWcdA-Is-35@gated-at.bofh.it> <sWcwW-Vl-41@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Thu, Jan 5, 2017 at 11:19 AM, Boris Brezillon
<boris.brezillon@free-electrons.com> wrote:
> On Thu, 5 Jan 2017 10:03:47 +0100
> Lukasz Majewski <lukma@denx.de> wrote:
>> >             /*
>> >              * Wait for a free FIFO slot if the PWM is already
>> > enabled, and
>> >              * flush the FIFO if the PWM was disabled and is
>> > about to be
>> >              * enabled.
>> >              */

>> >             if (cstate.enabled) {

if (pwm_is_enabled()) ?

I think it's better to do whatever API provides to be less error prone.

>> >                     imx_pwm_wait_fifo_slot(chip, pwm);
>> >             } else {
>> >                     ret = clk_prepare_enable(imx->clk_per);
>> >                     if (ret)
>> >                             return ret;

>> if (state.enabled && !cstate.enabled)
>>       clk_preapre_enable();
>
> Yep, and that's correct.

!pwm_is_enabled() ?

-- 
With Best Regards,
Andy Shevchenko

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v4 07/11] pwm: imx: Provide atomic PWM support for i.MX PWMv2 Lukasz Majewski <lukma@denx.de> - 2017-01-05 00:40 +0100
  Re: [PATCH v4 07/11] pwm: imx: Provide atomic PWM support for i.MX  PWMv2 Boris Brezillon <boris.brezillon@free-electrons.com> - 2017-01-05 10:00 +0100
    Re: [PATCH v4 07/11] pwm: imx: Provide atomic PWM support for i.MX  PWMv2 Lukasz Majewski <lukma@denx.de> - 2017-01-05 10:10 +0100
      Re: [PATCH v4 07/11] pwm: imx: Provide atomic PWM support for i.MX  PWMv2 Boris Brezillon <boris.brezillon@free-electrons.com> - 2017-01-05 10:30 +0100
        Re: [PATCH v4 07/11] pwm: imx: Provide atomic PWM support for i.MX  PWMv2 Lukasz Majewski <lukma@denx.de> - 2017-01-05 10:50 +0100
          Re: [PATCH v4 07/11] pwm: imx: Provide atomic PWM support for i.MX  PWMv2 Boris Brezillon <boris.brezillon@free-electrons.com> - 2017-01-05 11:10 +0100
            Re: [PATCH v4 07/11] pwm: imx: Provide atomic PWM support for i.MX  PWMv2 Stefan Agner <stefan@agner.ch> - 2017-01-10 04:20 +0100
              Re: [PATCH v4 07/11] pwm: imx: Provide atomic PWM support for i.MX  PWMv2 Boris Brezillon <boris.brezillon@free-electrons.com> - 2017-01-10 09:00 +0100
        Re: [PATCH v4 07/11] pwm: imx: Provide atomic PWM support for i.MX PWMv2 Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-01-05 22:30 +0100
          Re: [PATCH v4 07/11] pwm: imx: Provide atomic PWM support for i.MX  PWMv2 Boris Brezillon <boris.brezillon@free-electrons.com> - 2017-01-06 08:10 +0100
        Re: [PATCH v4 07/11] pwm: imx: Provide atomic PWM support for i.MX  PWMv2 Lukasz Majewski <lukma@denx.de> - 2017-01-07 19:40 +0100

csiph-web