Re: [PATCH] pinctrl: core: Fix panic when pinctrl devices with hogs are unregistered

From	Tony Lindgren <tony@atomide.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] pinctrl: core: Fix panic when pinctrl devices with hogs are unregistered
Date	2017-01-05 20:40 +0100
Message-ID	<sWm3g-7kY-29@gated-at.bofh.it> (permalink)
References	<sWiCl-50p-25@gated-at.bofh.it> <sWiVI-5on-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

* Linus Walleij <linus.walleij@linaro.org> [170105 08:16]:
> On Thu, Jan 5, 2017 at 4:52 PM, Jon Hunter <jonathanh@nvidia.com> wrote:
> 
> > Commit df61b366af26 ('pinctrl: core: Use delayed work for hogs')
> > deferred part of the registration for pinctrl devices if the pinctrl
> > device has hogs. This introduced a window where if the pinctrl device
> > with hogs was sucessfully registered, but then unregistered again
> > (which could be caused by parent device being probe deferred) before
> > the delayed work has chanced to run, then this will cause a kernel
> > panic to occur because:
> >
> > 1. The 'pctldev->p' has not yet been initialised and when unregistering
> >    the pinctrl device we only check to see if it is an error value, but
> >    now it could also be NULL.
> > 2. The pinctrl device may not have been added to the 'pinctrldev_list'
> >    list and we don't check to see if it was added before removing.
> >
> > Fix up the above by checking to see if the 'pctldev->p' pointer is an
> > error value or NULL before putting the pinctrl device and verifying
> > that the pinctrl device is present in 'pinctrldev_list' before removing.
> >
> > Fixes: df61b366af26 ('pinctrl: core: Use delayed work for hogs')
> >
> > Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
> 
> Oops. Patch applied.

OK, did not see that with my testing of hogs with omap4-duovero-parlor.
Thanks for fixing that.

Tony

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] pinctrl: core: Fix panic when pinctrl devices with hogs are unregistered Jon Hunter <jonathanh@nvidia.com> - 2017-01-05 17:00 +0100
  Re: [PATCH] pinctrl: core: Fix panic when pinctrl devices with hogs  are unregistered Linus Walleij <linus.walleij@linaro.org> - 2017-01-05 17:20 +0100
    Re: [PATCH] pinctrl: core: Fix panic when pinctrl devices with hogs  are unregistered Tony Lindgren <tony@atomide.com> - 2017-01-05 20:40 +0100

csiph-web