Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1551733

Re: [PATCH 05/22] ARM: dtsi: axp209: add AXP209 ADC subnode

From Quentin Schulz <quentin.schulz@free-electrons.com>
Newsgroups linux.kernel
Subject Re: [PATCH 05/22] ARM: dtsi: axp209: add AXP209 ADC subnode
Date 2017-01-05 09:20 +0100
Message-ID <sWbrb-bR-5@gated-at.bofh.it> (permalink)
References <sVdY5-1dY-17@gated-at.bofh.it> <sViuJ-4xe-1@gated-at.bofh.it> <sWals-7XR-1@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On 05/01/2017 06:51, Chen-Yu Tsai wrote:
> On Tue, Jan 3, 2017 at 12:37 AM, Quentin Schulz
> <quentin.schulz@free-electrons.com> wrote:
>> X-Powers AXP209 PMIC has multiple ADCs, each one exposing data from the
>> different power supplies connected to the PMIC.
>>
>> This adds the ADC subnode for AXP20X PMIC.
>>
>> Signed-off-by: Quentin Schulz <quentin.schulz@free-electrons.com>
>> ---
>>  arch/arm/boot/dts/axp209.dtsi | 5 +++++
>>  1 file changed, 5 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/axp209.dtsi b/arch/arm/boot/dts/axp209.dtsi
>> index 675bb0f..2a4e8ee 100644
>> --- a/arch/arm/boot/dts/axp209.dtsi
>> +++ b/arch/arm/boot/dts/axp209.dtsi
>> @@ -53,6 +53,11 @@
>>         interrupt-controller;
>>         #interrupt-cells = <1>;
>>
>> +       axp209_adc: axp209_adc {
> 
> Node name should be generic. Please change it to "adc".
> 

OK, do I keep the label as is?

axp209_adc: adc {

Thanks,
Quentin

-- 
Quentin Schulz, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

Re: [PATCH 05/22] ARM: dtsi: axp209: add AXP209 ADC subnode Chen-Yu Tsai <wens@csie.org> - 2017-01-05 08:10 +0100
  Re: [PATCH 05/22] ARM: dtsi: axp209: add AXP209 ADC subnode Quentin Schulz <quentin.schulz@free-electrons.com> - 2017-01-05 09:20 +0100
    Re: [PATCH 05/22] ARM: dtsi: axp209: add AXP209 ADC subnode Chen-Yu Tsai <wens@csie.org> - 2017-01-05 10:10 +0100

csiph-web