Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1551670

Re: [PATCH v6 1/5] dt-bindings: zte: documents zx2967 power domain driver bindings

From Shawn Guo <shawnguo@kernel.org>
Newsgroups linux.kernel
Subject Re: [PATCH v6 1/5] dt-bindings: zte: documents zx2967 power domain driver bindings
Date 2017-01-05 08:00 +0100
Message-ID <sWabL-7F6-9@gated-at.bofh.it> (permalink)
References <sVSeS-47P-17@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Wed, Jan 04, 2017 at 07:48:10PM +0800, Baoyou Xie wrote:
> This patch documents devicetree tree bindings for the ZTE zx2967

'devicetree' is good enough, and the 'tree' after it is redundant.

> power domain driver.

DT bindings is to describe hardware block not software, so the word like
'driver' is not appropriate.  So please drop it from here and the patch
subject.

> 
> Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
> ---
>  Documentation/devicetree/bindings/soc/zte/pd-2967xx.txt | 17 +++++++++++++++++
>  1 file changed, 17 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/soc/zte/pd-2967xx.txt
> 
> diff --git a/Documentation/devicetree/bindings/soc/zte/pd-2967xx.txt b/Documentation/devicetree/bindings/soc/zte/pd-2967xx.txt
> new file mode 100644
> index 0000000..1476318
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/soc/zte/pd-2967xx.txt
> @@ -0,0 +1,17 @@
> +* ZTE 2967 SoC Power Domains

ZTE ZX2967 family.  And this is a bindings document for PCU, IMO.  And
do we know the full name of abbreviation 'PCU'?  Power Control Unit?

> +
> +2967 processors include support for multiple power domains which are used

ZX2967 family

> +to gate power to one or more peripherals on the processor.
> +
> +Required Properties:
> +- compatible: should be one of the following.
> +    * zte,zx296718-pcu - for zx296718 board's power domain.

Drop 'board's'.

> +- reg: physical base address of the controller and length of memory mapped
> +    region.
> +
> +Example:
> +
> +	pcu_domain: pcu@0x00117000 {

The unit-address in node name shouldn't have 0x and leading zeros.

	pcu_domain: pcu@117000 {

Shawn

> +		compatible = "zte,zx296718-pcu";
> +		reg = <0x00117000 0x1000>;
> +	};
> -- 
> 2.7.4
> 

Back to linux.kernel | Previous | NextPrevious in thread | Find similar | Unroll thread


Thread

[PATCH v6 1/5] dt-bindings: zte: documents zx2967 power domain driver bindings Baoyou Xie <baoyou.xie@linaro.org> - 2017-01-04 12:50 +0100
  [PATCH v6 4/5] soc: zte: pm_domains: Prepare for supporting ARMv8 zx2967 family Baoyou Xie <baoyou.xie@linaro.org> - 2017-01-04 12:50 +0100
    Re: [PATCH v6 4/5] soc: zte: pm_domains: Prepare for supporting  ARMv8 zx2967 family Shawn Guo <shawnguo@kernel.org> - 2017-01-05 08:10 +0100
  [PATCH v6 5/5] soc: zte: pm_domains: Add support for zx296718 Baoyou Xie <baoyou.xie@linaro.org> - 2017-01-04 13:00 +0100
    Re: [PATCH v6 5/5] soc: zte: pm_domains: Add support for zx296718 Shawn Guo <shawnguo@kernel.org> - 2017-01-05 08:50 +0100
  Re: [PATCH v6 1/5] dt-bindings: zte: documents zx2967 power domain  driver bindings Rob Herring <robh@kernel.org> - 2017-01-04 16:00 +0100
  Re: [PATCH v6 1/5] dt-bindings: zte: documents zx2967 power domain  driver bindings Shawn Guo <shawnguo@kernel.org> - 2017-01-05 08:00 +0100

csiph-web