Re: [RFC PATCH] ext4: convert swap_inode_data() over to use swap() on most of the fields

From	Jan Kara <jack@suse.cz>
Newsgroups	linux.kernel
Subject	Re: [RFC PATCH] ext4: convert swap_inode_data() over to use swap() on most of the fields
Date	2017-01-05 08:30 +0100
Message-ID	<sWaEN-85U-1@gated-at.bofh.it> (permalink)
References	<sQuZz-7tt-7@gated-at.bofh.it> <sVVZ7-6Ac-5@gated-at.bofh.it> <sW0m7-1bZ-51@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed 04-01-17 15:21:28, Jeff Layton wrote:
> On Wed, 2017-01-04 at 16:43 +0100, Jan Kara wrote:
> > On Tue 20-12-16 10:55:41, Jeff Layton wrote:
> > > 
> > > For some odd reason, it forces a byte-by-byte copy of each field. A
> > > plain old swap() on most of these fields would be more efficient. We
> > > do need to retain one memswap however as that field is an array.
> > > 
> > > Signed-off-by: Jeff Layton <jlayton@redhat.com>
> > 
> > Looks good to me. You can add:
> > 
> > Reviewed-by: Jan Kara <jack@suse.cz>
> > 
> > 								Honza
> > 
> 
> Thanks. Yeah, it's certainly nothing critical -- just something I
> noticed while looking at the i_version rework. Seems like it might be
> good to let soak in next for v4.11?

Yeah, it is definitely 4.11 material. I believe he'll pick up the patch to
his tree once he starts accumulating patches for the next merge window.

								Honza
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [RFC PATCH] ext4: convert swap_inode_data() over to use swap()  on most of the fields Jan Kara <jack@suse.cz> - 2017-01-04 16:50 +0100
  Re: [RFC PATCH] ext4: convert swap_inode_data() over to use swap()  on most of the fields Jeff Layton <jlayton@redhat.com> - 2017-01-04 21:30 +0100
    Re: [RFC PATCH] ext4: convert swap_inode_data() over to use swap()  on most of the fields Jan Kara <jack@suse.cz> - 2017-01-05 08:30 +0100

csiph-web