Re: [PATCH v2 3/4] hv_util: use do_adjtimex() to update system time

Path	csiph.com!1.us.feeder.erje.net!feeder.erje.net!2.eu.feeder.erje.net!news.unit0.net!news.panservice.it!bofh.it!news.nic.it!robomod
From	John Stultz <john.stultz@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 3/4] hv_util: use do_adjtimex() to update system time
Date	Sat, 07 Jan 2017 02:00:01 +0100
Message-ID	<sWNwt-1nt-5@gated-at.bofh.it> (permalink)
References	<sVXHA-7LF-27@gated-at.bofh.it> <sVXHA-7LF-25@gated-at.bofh.it>
X-Original-To	Vitaly Kuznetsov <vkuznets@redhat.com>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=aakhCxbExDwnc+Vpn8m8dw9SChfQ6v/V3LfHPGpNHU4=; b=WRvOu30sWw503BfESI41kz+y/Tsymv8SIHLhd44SFU6FlA0+nCTKgMElGqIpbsuMMC LxEYJ1bb3UzKo/UMk19rIHNtvr8lhqd6p40ac/wzIWuMvPRKE6nADtdsrgS2WjA5TUOt xucHf2WdzYpxlawXuvV5gfM2gCD+6jisg0Vug=
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=aakhCxbExDwnc+Vpn8m8dw9SChfQ6v/V3LfHPGpNHU4=; b=AzUQ9xzLTIRwSuye0V84eM7KesWvEGN0DjdV8qvSmnmXawNhMKay60HCPkJ7AD82FR qx8JmJg5T1F61YJHO56AFwpI69o/ZM6hvwve4/xH6PhMXXd9peBI0x625CRzXND0zfFq xyfPRCSpEIa6esP+ZRu2BnIgUw80tGGOaj0AmatDWmQ9tDeD3yABllGr+0oDyOwjZApp anExItv63UknnRVa7G+PMR52qK1NA+IwfvLTaoNw95r7tORt2uVgXY16FXlmkcQm6Glv ydjocYgg8xg1MnSnjSalhesE3rquef4Qrzrym7ln5UBD0KgYBsgVTKJzUD/AtqiXv1Z+ 9eCQ==
X-Gm-Message-State	AIkVDXK/GJ7393MaCEeWnXeWy368ESaKW1lVeMxGgMEnAlEGSVVVRu8s04/D+2udnb0AQYkmDJgaMwoBz9OJ1NUT
X-Received	by 10.157.42.19 with SMTP id t19mr2206183ota.257.1483750584577; Fri, 06 Jan 2017 16:56:24 -0800 (PST)
MIME-Version	1.0
Content-Type	text/plain; charset=UTF-8
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	25
Organization	linux.* mail to news gateway
X-Original-Cc	"devel@linuxdriverproject.org" <devel@linuxdriverproject.org>, lkml <linux-kernel@vger.kernel.org>, "K. Y. Srinivasan" <kys@microsoft.com>, Haiyang Zhang <haiyangz@microsoft.com>, Thomas Gleixner <tglx@linutronix.de>, Alex Ng <alexng@microsoft.com>, Stephen Hemminger <stephen@networkplumber.org>
X-Original-Date	Fri, 6 Jan 2017 16:56:23 -0800
X-Original-Message-ID	<CALAqxLXQbXgYbA4gS9ju7iEQRu_s4eMCEneiaJY0JGpQh+Qu2A@mail.gmail.com>
X-Original-References	<20170104172439.19683-1-vkuznets@redhat.com> <20170104172439.19683-4-vkuznets@redhat.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1553520

Show key headers only | View raw

On Wed, Jan 4, 2017 at 9:24 AM, Vitaly Kuznetsov <vkuznets@redhat.com> wrote:
> With TimeSync version 4 protocol support we started updating system time
> continuously through the whole lifetime of Hyper-V guests. Every 5 seconds
> there is a time sample from the host which triggers do_settimeofday[64]().
> While the time from the host is very accurate such adjustments may cause
> issues:
> - Time is jumping forward and backward, some applications may misbehave.
> - In case an NTP client is run in parallel things may go south, e.g. when
>   an NTP client tries to adjust tick/frequency with ADJ_TICK/ADJ_FREQUENCY
>   the Hyper-V module will not see this changes and time will oscillate and
>   never converge.
> - Systemd starts annoying you by printing "Time has been changed" every 5
>   seconds to the system log.
>
> Instead of calling do_settimeofday64() we can pretend being an NTP client
> and use do_adjtimex(). Do do_settimeofday64() in case the difference is too
> big or ICTIMESYNCFLAG_SYNC flag was set in the request.

So how does having the guest kernel (on behalf of the host) calling
adjtimex internally interact with NTP clients running on the guest?
The kernel sort of assumes a single user of adjtimex (having multiple
clients adjusting the clock doesn't work out so well).

thanks
-john

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2 3/4] hv_util: use do_adjtimex() to update system time Vitaly Kuznetsov <vkuznets@redhat.com> - 2017-01-04 18:40 +0100
  Re: [PATCH v2 3/4] hv_util: use do_adjtimex() to update system time Stephen Hemminger <stephen@networkplumber.org> - 2017-01-04 20:20 +0100
    Re: [PATCH v2 3/4] hv_util: use do_adjtimex() to update system time Vitaly Kuznetsov <vkuznets@redhat.com> - 2017-01-05 13:50 +0100
  Re: [PATCH v2 3/4] hv_util: use do_adjtimex() to update system time John Stultz <john.stultz@linaro.org> - 2017-01-07 02:00 +0100

csiph-web