Re: [PATCH 1/5] ARM: dts: qcom: apq8064: Add missing scm clock

From	John Stultz <john.stultz@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/5] ARM: dts: qcom: apq8064: Add missing scm clock
Date	2017-01-07 02:20 +0100
Message-ID	<sWNPP-1Ls-1@gated-at.bofh.it> (permalink)
References	<sQV3H-7Bc-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Dec 21, 2016 at 3:49 AM, Bjorn Andersson
<bjorn.andersson@linaro.org> wrote:
> As per the device tree binding the apq8064 scm node requires the core
> clock to be specified, so add this.
>
> Cc: John Stultz <john.stultz@linaro.org>
> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> ---
>  arch/arm/boot/dts/qcom-apq8064.dtsi | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/arch/arm/boot/dts/qcom-apq8064.dtsi b/arch/arm/boot/dts/qcom-apq8064.dtsi
> index 268bd470c865..78bf155a52f3 100644
> --- a/arch/arm/boot/dts/qcom-apq8064.dtsi
> +++ b/arch/arm/boot/dts/qcom-apq8064.dtsi
> @@ -303,6 +303,9 @@
>         firmware {
>                 scm {
>                         compatible = "qcom,scm-apq8064";
> +
> +                       clocks = <&gcc CE3_CORE_CLK>;
> +                       clock-names = "core";


Tested-by: John Stultz <john.stultz@linaro.org>

I know Bjorn has a new version of this patch that uses the
RPM_DAYTONA_FABRIC_CLK value, but that one results in problems with
usb gadget functionality on my Nexus7.  This one seems to work ok
though.

thanks
-john

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH 1/5] ARM: dts: qcom: apq8064: Add missing scm clock John Stultz <john.stultz@linaro.org> - 2017-01-07 02:20 +0100
  Re: [PATCH 1/5] ARM: dts: qcom: apq8064: Add missing scm clock Andy Gross <andy.gross@linaro.org> - 2017-01-07 04:10 +0100
    Re: [PATCH 1/5] ARM: dts: qcom: apq8064: Add missing scm clock Bjorn Andersson <bjorn.andersson@linaro.org> - 2017-01-07 08:40 +0100

csiph-web