Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1553515
| From | Steve Longerbeam <slongerbeam@gmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v2 05/19] ARM: dts: imx6-sabresd: add OV5642 and OV5640 camera sensors |
| Date | 2017-01-07 01:30 +0100 |
| Message-ID | <sWN3r-1cB-1@gated-at.bofh.it> (permalink) |
| References | <sVElz-3en-7@gated-at.bofh.it> <sVEvh-3xp-79@gated-at.bofh.it> <sVVFL-6tl-15@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 01/04/2017 07:26 AM, Fabio Estevam wrote:
> On Tue, Jan 3, 2017 at 6:57 PM, Steve Longerbeam <slongerbeam@gmail.com> wrote:
>
>> + camera: ov5642@3c {
>> + compatible = "ovti,ov5642";
>> + pinctrl-names = "default";
>> + pinctrl-0 = <&pinctrl_ov5642>;
>> + clocks = <&clks IMX6QDL_CLK_CKO>;
>> + clock-names = "xclk";
>> + reg = <0x3c>;
>> + xclk = <24000000>;
>> + DOVDD-supply = <&vgen4_reg>; /* 1.8v */
>> + AVDD-supply = <&vgen5_reg>; /* 2.8v, rev C board is VGEN3
>> + rev B board is VGEN5 */
> Please use vgen3 so that by default we have the valid AVDD-supply for
> revC boards which is more recent and more the users have access to.
done.
>
>> + mipi_camera: ov5640@3c {
>> + compatible = "ovti,ov5640_mipi";
>> + pinctrl-names = "default";
>> + pinctrl-0 = <&pinctrl_ov5640>;
>> + reg = <0x3c>;
>> + clocks = <&clks IMX6QDL_CLK_CKO>;
>> + clock-names = "xclk";
>> + xclk = <24000000>;
>> + DOVDD-supply = <&vgen4_reg>; /* 1.8v */
>> + AVDD-supply = <&vgen5_reg>; /* 2.8v, rev C board is VGEN3
>> + rev B board is VGEN5 */
> Same here.
done.
>
>> + pinctrl_ov5640: ov5640grp {
>> + fsl,pins = <
>> + MX6QDL_PAD_SD1_DAT2__GPIO1_IO19 0x80000000
>> + MX6QDL_PAD_SD1_CLK__GPIO1_IO20 0x80000000
> Please avoid all the 0x80000000 IOMUX settings and replace them by
> their real values.
yeah, finally got around to this, done!
Steve
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v2 00/19] i.MX Media Driver Steve Longerbeam <slongerbeam@gmail.com> - 2017-01-03 22:10 +0100
[PATCH v2 07/19] ARM: dts: imx6-sabreauto: add reset-gpios property for max7310_b Steve Longerbeam <slongerbeam@gmail.com> - 2017-01-03 22:10 +0100
[PATCH v2 19/19] ARM: imx_v6_v7_defconfig: Enable staging video4linux drivers Steve Longerbeam <slongerbeam@gmail.com> - 2017-01-03 22:10 +0100
[PATCH v2 06/19] ARM: dts: imx6-sabreauto: create i2cmux for i2c3 Steve Longerbeam <slongerbeam@gmail.com> - 2017-01-03 22:10 +0100
[PATCH v2 05/19] ARM: dts: imx6-sabresd: add OV5642 and OV5640 camera sensors Steve Longerbeam <slongerbeam@gmail.com> - 2017-01-03 22:10 +0100
Re: [PATCH v2 05/19] ARM: dts: imx6-sabresd: add OV5642 and OV5640 camera sensors Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com> - 2017-01-04 13:40 +0100
Re: [PATCH v2 05/19] ARM: dts: imx6-sabresd: add OV5642 and OV5640 camera sensors Steve Longerbeam <slongerbeam@gmail.com> - 2017-01-05 23:40 +0100
Re: [PATCH v2 05/19] ARM: dts: imx6-sabresd: add OV5642 and OV5640 camera sensors Fabio Estevam <festevam@gmail.com> - 2017-01-04 16:30 +0100
Re: [PATCH v2 05/19] ARM: dts: imx6-sabresd: add OV5642 and OV5640 camera sensors Steve Longerbeam <slongerbeam@gmail.com> - 2017-01-07 01:30 +0100
Re: [PATCH v2 00/19] i.MX Media Driver Fabio Estevam <festevam@gmail.com> - 2017-01-03 22:20 +0100
Re: [PATCH v2 10/19] media: Add i.MX media core driver Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com> - 2017-01-04 14:50 +0100
Re: [PATCH v2 10/19] media: Add i.MX media core driver Steve Longerbeam <slongerbeam@gmail.com> - 2017-01-06 02:30 +0100
Re: [PATCH v2 13/19] media: imx: Add IC subdev drivers Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com> - 2017-01-04 16:00 +0100
Re: [PATCH v2 13/19] media: imx: Add IC subdev drivers Steve Longerbeam <slongerbeam@gmail.com> - 2017-01-06 19:40 +0100
csiph-web