Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1553428

Re: [PATCH] usb: dwc2: use u32 for DT binding parameters

Show all headers | View raw

On Fri, Jan 6, 2017 at 4:45 AM, Leo Yan <leo.yan@linaro.org> wrote:
> Commit 05ee799f2021 ("usb: dwc2: Move gadget settings into core_params")
> changes to type u16 for DT binding "g-rx-fifo-size" and
> "g-np-tx-fifo-size" but use type u32 for "g-tx-fifo-size". Finally the
> the first two parameters cannot be passed successfully with wrong data
> format. This is found the data transferring broken on 96boards Hikey.
>
> This patch is to change all parameters to u32 type, and verified on
> Hikey board the DT parameters can pass successfully.
>
> Signed-off-by: Leo Yan <leo.yan@linaro.org>

Nice!

This patch (while it doesn't apply cleanly to v4.10-rc2) does resolve
the regression I reported earlier here:
https://www.spinics.net/lists/linux-usb/msg150766.html

I didn't see the slight shift to u16s there.

Leo, does the patch need a respin, or is it against Linus' HEAD and my
tree is stale?

Anyway, after re-applying it to my tree:
Tested-by: John Stultz <john.stultz@linaro.org>

thanks
-john

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] usb: dwc2: use u32 for DT binding parameters Leo Yan <leo.yan@linaro.org> - 2017-01-06 14:00 +0100
  Re: [PATCH] usb: dwc2: use u32 for DT binding parameters John Stultz <john.stultz@linaro.org> - 2017-01-07 00:00 +0100
    Re: [PATCH] usb: dwc2: use u32 for DT binding parameters John Youn <John.Youn@synopsys.com> - 2017-01-07 04:40 +0100
      Re: [PATCH] usb: dwc2: use u32 for DT binding parameters Leo Yan <leo.yan@linaro.org> - 2017-01-07 10:40 +0100

csiph-web