Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1553149
| From | Andy Shevchenko <andy.shevchenko@gmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] i2c: core: helper function to detect slave mode |
| Date | 2017-01-06 22:40 +0100 |
| Message-ID | <sWKoV-7NO-29@gated-at.bofh.it> (permalink) |
| References | <sWk1s-63E-27@gated-at.bofh.it> <sWFIB-4w8-7@gated-at.bofh.it> <sWGlk-52t-9@gated-at.bofh.it> <sWGlk-52t-15@gated-at.bofh.it> <sWGOl-5dK-3@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Fri, Jan 6, 2017 at 7:46 PM, Luis Oliveira <Luis.Oliveira@synopsys.com> wrote: > On 06-Jan-17 17:17, Andy Shevchenko wrote: >> On Fri, Jan 6, 2017 at 7:15 PM, Luis Oliveira >> <Luis.Oliveira@synopsys.com> wrote: >>> On 06-Jan-17 16:29, Andy Shevchenko wrote: >>>> On Thu, Jan 5, 2017 at 7:24 PM, Luis Oliveira >> >>>> Please, add kernel doc description here, important thing is to explain >>>> return codes in Return: section of it. >>>> >>>>> +int i2c_slave_mode_detect(struct device *dev) >> >> Just to make sure you didn't miss this one. >> >> > Yes, I saw it. You were talking of something like this, right? > > /** > * i2c_slave_mode_detect - detect operation mode > * @dev: The device owning the bus > * > * This checks the device nodes for a I2C slave by checking the address a -> an > * used. > * > * Returns true if a I2C slave is detected, otherwise returns false. It has int type and I would reword this accordingly. Something like * Return: * 1 when an I2C slave is detected, 0 for I2C master mode, * and negative error otherwise. > */ -- With Best Regards, Andy Shevchenko
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] i2c: core: helper function to detect slave mode Luis Oliveira <Luis.Oliveira@synopsys.com> - 2017-01-05 18:30 +0100
Re: [PATCH] i2c: core: helper function to detect slave mode Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-01-06 17:40 +0100
Re: [PATCH] i2c: core: helper function to detect slave mode Luis Oliveira <Luis.Oliveira@synopsys.com> - 2017-01-06 18:20 +0100
Re: [PATCH] i2c: core: helper function to detect slave mode Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-01-06 18:20 +0100
Re: [PATCH] i2c: core: helper function to detect slave mode Luis Oliveira <Luis.Oliveira@synopsys.com> - 2017-01-06 18:50 +0100
Re: [PATCH] i2c: core: helper function to detect slave mode Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-01-06 22:40 +0100
Re: [PATCH] i2c: core: helper function to detect slave mode Rob Herring <robh+dt@kernel.org> - 2017-01-06 17:40 +0100
Re: [PATCH] i2c: core: helper function to detect slave mode Luis Oliveira <Luis.Oliveira@synopsys.com> - 2017-01-06 18:20 +0100
Re: [PATCH] i2c: core: helper function to detect slave mode Vladimir Zapolskiy <vz@mleia.com> - 2017-01-06 22:50 +0100
Re: [PATCH] i2c: core: helper function to detect slave mode Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-01-06 23:50 +0100
Re: [PATCH] i2c: core: helper function to detect slave mode Vladimir Zapolskiy <vz@mleia.com> - 2017-01-07 00:50 +0100
Re: [PATCH] i2c: core: helper function to detect slave mode Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-01-07 01:30 +0100
Re: [PATCH] i2c: core: helper function to detect slave mode Vladimir Zapolskiy <vz@mleia.com> - 2017-01-07 02:30 +0100
Re: [PATCH] i2c: core: helper function to detect slave mode Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-01-12 18:10 +0100
Re: [PATCH] i2c: core: helper function to detect slave mode Luis Oliveira <Luis.Oliveira@synopsys.com> - 2017-01-16 11:50 +0100
csiph-web