Re: [PATCH v3 15/15] livepatch: allow removal of a disabled patch

From	Josh Poimboeuf <jpoimboe@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 15/15] livepatch: allow removal of a disabled patch
Date	2017-01-06 22:10 +0100
Message-ID	<sWJVU-7yR-45@gated-at.bofh.it> (permalink)
References	<sMbst-Yb-9@gated-at.bofh.it> <sMbsu-Yb-49@gated-at.bofh.it> <sVVcJ-62m-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Jan 04, 2017 at 03:57:09PM +0100, Miroslav Benes wrote:
> 
> > diff --git a/samples/livepatch/livepatch-sample.c b/samples/livepatch/livepatch-sample.c
> > index bb61c65..0625f38 100644
> > --- a/samples/livepatch/livepatch-sample.c
> > +++ b/samples/livepatch/livepatch-sample.c
> > @@ -89,7 +89,6 @@ static int livepatch_init(void)
> >  
> >  static void livepatch_exit(void)
> >  {
> > -	WARN_ON(klp_disable_patch(&patch));
> >  	WARN_ON(klp_unregister_patch(&patch));
> >  }
> 
> Btw, we remove the only call to klp_disable_patch() here. Maybe we can 
> remove the function completely. It is not needed anywhere.

Maybe so.  I haven't heard of anybody needing this interface.

-- 
Josh

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v3 15/15] livepatch: allow removal of a disabled patch Miroslav Benes <mbenes@suse.cz> - 2017-01-04 16:00 +0100
  Re: [PATCH v3 15/15] livepatch: allow removal of a disabled patch Josh Poimboeuf <jpoimboe@redhat.com> - 2017-01-06 22:10 +0100

csiph-web