Re: [PATCH v3 13/15] livepatch: change to a per-task consistency model

From	Josh Poimboeuf <jpoimboe@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 13/15] livepatch: change to a per-task consistency model
Date	2017-01-06 22:10 +0100
Message-ID	<sWJVT-7yR-35@gated-at.bofh.it> (permalink)
References	<sMbst-Yb-9@gated-at.bofh.it> <sMbsu-Yb-45@gated-at.bofh.it> <sWcGB-15H-21@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Jan 05, 2017 at 10:34:57AM +0100, Miroslav Benes wrote:
> 
> > @@ -740,6 +809,14 @@ int klp_register_patch(struct klp_patch *patch)
> >  		return -ENODEV;
> >  
> >  	/*
> > +	 * Architectures without reliable stack traces have to set
> > +	 * patch->immediate because there's currently no way to patch kthreads
> > +	 * with the consistency model.
> > +	 */
> > +	if (!klp_have_reliable_stack() && !patch->immediate)
> > +		return -ENOSYS;
> > +
> 
> I think an error message (pr_err) would be appropriate here. 
> 
> $ insmod patch_1.ko
> insmod: ERROR: could not insert module patch_1.ko: Function not implemented
> 
> is not helpful much :)

Ok :-)

-- 
Josh

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v3 13/15] livepatch: change to a per-task consistency  model Miroslav Benes <mbenes@suse.cz> - 2017-01-05 10:40 +0100
  Re: [PATCH v3 13/15] livepatch: change to a per-task consistency  model Josh Poimboeuf <jpoimboe@redhat.com> - 2017-01-06 22:10 +0100

csiph-web