Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1553101

Re: [PATCH] platform/x86: fujitsu-laptop: rework logolamp_set() to properly handle errors

From Andy Shevchenko <andy.shevchenko@gmail.com>
Newsgroups linux.kernel
Subject Re: [PATCH] platform/x86: fujitsu-laptop: rework logolamp_set() to properly handle errors
Date 2017-01-06 21:50 +0100
Message-ID <sWJCx-7a6-19@gated-at.bofh.it> (permalink)
References <sWg7w-3sQ-1@gated-at.bofh.it> <sWECR-3O1-1@gated-at.bofh.it> <sWIn7-6oa-1@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Fri, Jan 6, 2017 at 9:24 PM, Michał Kępień <kernel@kempniu.pl> wrote:
>> On Thu, Jan 5, 2017 at 3:11 PM, Michał Kępień <kernel@kempniu.pl> wrote:

>> > +       int ret, poweron = FUNC_LED_OFF, always = FUNC_LED_OFF;
>> > +

Don't know if you are already about to send v2, though I would see two
lines of above instead of one.
int ...;
int ret;


-- 
With Best Regards,
Andy Shevchenko

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] platform/x86: fujitsu-laptop: rework logolamp_set() to properly handle errors Michał Kępień <kernel@kempniu.pl> - 2017-01-05 14:20 +0100
  Re: [PATCH] platform/x86: fujitsu-laptop: rework logolamp_set() to  properly handle errors Jonathan Woithe <jwoithe@just42.net> - 2017-01-05 15:10 +0100
  Re: [PATCH] platform/x86: fujitsu-laptop: rework logolamp_set() to  properly handle errors Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-01-06 16:30 +0100
    Re: [PATCH] platform/x86: fujitsu-laptop: rework logolamp_set() to  properly handle errors Michał Kępień <kernel@kempniu.pl> - 2017-01-06 20:30 +0100
      Re: [PATCH] platform/x86: fujitsu-laptop: rework logolamp_set() to  properly handle errors Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-01-06 21:50 +0100
      Re: [PATCH] platform/x86: fujitsu-laptop: rework logolamp_set() to  properly handle errors Jonathan Woithe <jwoithe@just42.net> - 2017-01-07 02:10 +0100

csiph-web