Re: [PATCH] mm: introduce kv[mz]alloc helpers

Path	csiph.com!1.us.feeder.erje.net!feeder.erje.net!2.eu.feeder.erje.net!news.in-chemnitz.de!news2.arglkargh.de!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From	Michal Hocko <mhocko@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] mm: introduce kv[mz]alloc helpers
Date	Fri, 06 Jan 2017 14:40:01 +0100
Message-ID	<sWCUp-2A2-23@gated-at.bofh.it> (permalink)
References	<sVb0e-7pH-41@gated-at.bofh.it> <sWCUp-2A2-25@gated-at.bofh.it>
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.6.0 (2016-04-01)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	20
Organization	linux.* mail to news gateway
X-Original-Cc	Andrew Morton <akpm@linux-foundation.org>, David Rientjes <rientjes@google.com>, Mel Gorman <mgorman@suse.de>, Johannes Weiner <hannes@cmpxchg.org>, Al Viro <viro@zeniv.linux.org.uk>, linux-mm@kvack.org, LKML <linux-kernel@vger.kernel.org>, kvm@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-security-module@vger.kernel.org, linux-ext4@vger.kernel.org, Joe Perches <joe@perches.com>, Anatoly Stepanov <astepanov@cloudlinux.com>, Paolo Bonzini <pbonzini@redhat.com>, Mike Snitzer <snitzer@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>, Theodore Ts'o <tytso@mit.edu>, Andreas Dilger <adilger@dilger.ca>
X-Original-Date	Fri, 6 Jan 2017 14:34:59 +0100
X-Original-Message-ID	<20170106133459.GM5556@dhcp22.suse.cz>
X-Original-References	<20170102133700.1734-1-mhocko@kernel.org> <747f7b9a-e95d-a872-7e30-ea235b91593a@suse.cz>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1552778

Show key headers only | View raw

On Fri 06-01-17 14:29:33, Vlastimil Babka wrote:
> On 01/02/2017 02:37 PM, Michal Hocko wrote:
> > --- a/drivers/vhost/vhost.c
> > +++ b/drivers/vhost/vhost.c
> > @@ -514,18 +514,9 @@ long vhost_dev_set_owner(struct vhost_dev *dev)
> >  }
> >  EXPORT_SYMBOL_GPL(vhost_dev_set_owner);
> >  
> > -static void *vhost_kvzalloc(unsigned long size)
> > -{
> > -	void *n = kzalloc(size, GFP_KERNEL | __GFP_NOWARN | __GFP_REPEAT);
> 
> Hi, I just noticed that this had __GFP_REPEAT, so you'll probably want
> to move these hunks to patch 3 with the rest of vhost.

Well, spotted. I will do that. Thanks!

-- 
Michal Hocko
SUSE Labs

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] mm: introduce kv[mz]alloc helpers Michal Hocko <mhocko@kernel.org> - 2017-01-06 14:40 +0100

csiph-web