[PATCH] i2c: print correct device invalid address

From	John Garry <john.garry@huawei.com>
Newsgroups	linux.kernel
Subject	[PATCH] i2c: print correct device invalid address
Date	2017-01-06 11:40 +0100
Message-ID	<sWA6d-s7-1@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

In of_i2c_register_device(), when the check for
device address validity fails we print the info.addr,
which has not been assigned properly.

Fix this by printing the actual invalid address.

Signed-off-by: John Garry <john.garry@huawei.com>

diff --git a/drivers/i2c/i2c-core.c b/drivers/i2c/i2c-core.c
index cf9e396..03cfcdd 100644
--- a/drivers/i2c/i2c-core.c
+++ b/drivers/i2c/i2c-core.c
@@ -1708,7 +1708,7 @@ static struct i2c_client *of_i2c_register_device(struct i2c_adapter *adap,
 
 	if (i2c_check_addr_validity(addr, info.flags)) {
 		dev_err(&adap->dev, "of_i2c: invalid addr=%x on %s\n",
-			info.addr, node->full_name);
+			addr, node->full_name);
 		return ERR_PTR(-EINVAL);
 	}
 
-- 
1.9.1

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] i2c: print correct device invalid address John Garry <john.garry@huawei.com> - 2017-01-06 11:40 +0100
  Re: [PATCH] i2c: print correct device invalid address Vladimir Zapolskiy <vz@mleia.com> - 2017-01-07 22:50 +0100
  Re: [PATCH] i2c: print correct device invalid address Wolfram Sang <wsa@the-dreams.de> - 2017-01-12 20:10 +0100

csiph-web