Re: [PATCH] scsi: qedi: return via va_end to match corresponding va_start

From	"Martin K. Petersen" <martin.petersen@oracle.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] scsi: qedi: return via va_end to match corresponding va_start
Date	2017-01-05 06:40 +0100
Message-ID	<sW8Wl-6Vv-9@gated-at.bofh.it> (permalink)
References	<sP1Gi-4Ql-17@gated-at.bofh.it>
Organization	Oracle Corporation

Show all headers | View raw

>>>>> "Colin" == Colin King <colin.king@canonical.com> writes:

Colin> Although on most systems va_end is a no-op, it is good practice
Colin> to use va_end on the function return path, especially since the
Colin> va_start documenation states:

Colin>   "Each invocation of va_start() must be matched by a
Colin>   corresponding
Colin>    invocation of va_end() in the same function."

Applied to 4.11/scsi-queue.

-- 
Martin K. Petersen	Oracle Linux Engineering

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] scsi: qedi: return via va_end to match corresponding va_start "Martin K. Petersen" <martin.petersen@oracle.com> - 2017-01-05 06:40 +0100

csiph-web