Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1551581

Re: [PATCH 1/2] mfd: micon: Add Buffalo Kurobox Pro, Terastation II Pro/Live driver

From Florian Fainelli <f.fainelli@gmail.com>
Newsgroups linux.kernel
Subject Re: [PATCH 1/2] mfd: micon: Add Buffalo Kurobox Pro, Terastation II Pro/Live driver
Date 2017-01-05 03:40 +0100
Message-ID <sW689-4TF-15@gated-at.bofh.it> (permalink)
References <sTws9-7uW-7@gated-at.bofh.it> <sTws9-7uW-5@gated-at.bofh.it> <sVRLP-3XT-13@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Le 01/04/17 à 03:22, Lee Jones a écrit :
> On Wed, 28 Dec 2016, Florian Fainelli wrote:
> 
>> This driver is currently only used to reboot the devices, but the
>> microcontroller hanging off UART1 on the Buffalo Kurobox Pro and
>> Terastation II Pro/Live is capable of a lot more than that, which we
>> will support in subsequent patches. For now, just add the reboot
>> functionality to make the kernel reboot correctly.
> 
> This is not an MFD driver.  You have written a UART driver.
> 
> Please relocate it to drivers/char/tty/serial.

Not that simple, and as explained in the cover letter the UART attached
micro controller can do a lot more than just reboot the machine, but
someone else is working on the driver, so this patch series can be ignored.
-- 
Florian

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

Re: [PATCH 1/2] mfd: micon: Add Buffalo Kurobox Pro, Terastation II  Pro/Live driver Lee Jones <lee.jones@linaro.org> - 2017-01-04 12:20 +0100
  Re: [PATCH 1/2] mfd: micon: Add Buffalo Kurobox Pro, Terastation II  Pro/Live driver Florian Fainelli <f.fainelli@gmail.com> - 2017-01-05 03:40 +0100
    Re: [PATCH 1/2] mfd: micon: Add Buffalo Kurobox Pro, Terastation II  Pro/Live driver Lee Jones <lee.jones@linaro.org> - 2017-01-05 08:50 +0100

csiph-web