Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1551400

Re: [PATCH] power_supply: wm97xx_battery: remove redundant 2nd null check on pdata

From Sebastian Reichel <sre@kernel.org>
Newsgroups linux.kernel
Subject Re: [PATCH] power_supply: wm97xx_battery: remove redundant 2nd null check on pdata
Date 2017-01-04 22:30 +0100
Message-ID <sW1ia-1Pn-27@gated-at.bofh.it> (permalink)
References <sTKOt-8iW-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


[Multipart message — attachments visible in raw view] - view raw

Hi Colin,

On Thu, Dec 29, 2016 at 03:23:12PM +0000, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> pdata is being null checked twice, the 2nd check is redundant code
> and can be removed.
> 
> Fixes CoverityScan CID 1392340 "Logically dead code"
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Thanks for your patch. I have queued it into power-supply's
for-next branch:

https://git.kernel.org/cgit/linux/kernel/git/sre/linux-power-supply.git/log/?h=for-next

-- Sebastian

Back to linux.kernel | Previous | Next | Find similar | Unroll thread


Thread

Re: [PATCH] power_supply: wm97xx_battery: remove redundant 2nd null  check on pdata Sebastian Reichel <sre@kernel.org> - 2017-01-04 22:30 +0100

csiph-web