Re: [PATCH] drivers: staging: fbtft: fix checkpatch error and udelay

From	Greg KH <gregkh@linuxfoundation.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] drivers: staging: fbtft: fix checkpatch error and udelay
Date	2017-01-03 16:30 +0100
Message-ID	<sVzce-8gh-1@gated-at.bofh.it> (permalink)
References	<sPNKV-3TD-5@gated-at.bofh.it> <sPZM5-4cU-15@gated-at.bofh.it> <sQaet-2xI-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Dec 19, 2016 at 07:44:42PM +0200, Ozgur Karatas wrote:
> 19.12.2016, 08:35, "Greg KH" <gregkh@linuxfoundation.org>:
> > On Sun, Dec 18, 2016 at 11:47:30AM -0600, Scott Matheina wrote:
> >>  These changes where identified by checkpatch.pl as needed changes to
> >>  align the code with the linux development coding style. The several
> >>  lines of text where aligned with the precending parenthesis.
> >>
> >>  Signed-off-by: Scott Matheina <scott@matheina.com>
> >>
> >>   Changes to be committed:
> >>          modified: drivers/staging/fbtft/fb_agm1264k-fl.c
> >
> > Why are these lines in the changelog text?
> 
> I checked with checkpatch script to code and give a some errors.
> So, the code have to "udelay(20)".
> 
> udelay(20);
> 
> I read to Documentation/timers/timers-howto.txt and
> this line incorrect, usleep_range need must be add defined U_DELAY and fixed.
> 
> udelay(U_DELAY, U_DELAY + 10);
> 
> finally:
> 
> $ checkpatch.pl  drivers/staging/fbtft/fb_agm1264k-fl.c  | grep total
> total: 0 errors
> 
> Signed-off-by: Ozgur Karatas <okaratas@member.fsf.org>
> 
> ---
>  drivers/staging/fbtft/fb_agm1264k-fl.c | 31 ++++++++++++-------------------
>  1 file changed, 12 insertions(+), 19 deletions(-)

You do realize there's nothing I can do with this patch as-is, right?
Please fix up the changelog text and resend it properly if you wish to
have it included.

thanks,

greg k-h

Thread

[PATCH v2] fix code alignment with open parenthesis Scott Matheina <scott@matheina.com> - 2016-12-18 18:50 +0100
  Re: [PATCH v2] fix code alignment with open parenthesis Greg KH <gregkh@linuxfoundation.org> - 2016-12-19 07:40 +0100
    Re: [PATCH] drivers: staging: fbtft: fix checkpatch error and udelay Ozgur Karatas <okaratas@member.fsf.org> - 2016-12-19 18:50 +0100
      Re: [PATCH] drivers: staging: fbtft: fix checkpatch error and udelay Greg KH <gregkh@linuxfoundation.org> - 2017-01-03 16:30 +0100
    Re: [PATCH v2] fix code alignment with open parenthesis Scott Matheina <scott@matheina.com> - 2016-12-20 01:40 +0100

csiph-web