Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1549780
| From | Stefan Hajnoczi <stefanha@gmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH net-next V2 3/3] tun: rx batching |
| Date | 2017-01-03 14:40 +0100 |
| Message-ID | <sVxtL-70z-15@gated-at.bofh.it> (permalink) |
| References | <sTht8-5vS-5@gated-at.bofh.it> <sTht8-5vS-3@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
[Multipart message — attachments visible in raw view] - view raw
On Wed, Dec 28, 2016 at 04:09:31PM +0800, Jason Wang wrote:
> +static int tun_rx_batched(struct tun_file *tfile, struct sk_buff *skb,
> + int more)
> +{
> + struct sk_buff_head *queue = &tfile->sk.sk_write_queue;
> + struct sk_buff_head process_queue;
> + int qlen;
> + bool rcv = false;
> +
> + spin_lock(&queue->lock);
Should this be spin_lock_bh()? Below and in tun_get_user() there are
explicit local_bh_disable() calls so I guess BHs can interrupt us here
and this would deadlock.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH net-next V2 3/3] tun: rx batching Jason Wang <jasowang@redhat.com> - 2016-12-28 09:10 +0100
Re: [PATCH net-next V2 3/3] tun: rx batching David Miller <davem@davemloft.net> - 2016-12-29 17:40 +0100
Re: [PATCH net-next V2 3/3] tun: rx batching Jason Wang <jasowang@redhat.com> - 2016-12-30 06:20 +0100
Re: [PATCH net-next V2 3/3] tun: rx batching Stefan Hajnoczi <stefanha@gmail.com> - 2017-01-03 14:40 +0100
Re: [PATCH net-next V2 3/3] tun: rx batching Jason Wang <jasowang@redhat.com> - 2017-01-04 04:10 +0100
Re: [PATCH net-next V2 3/3] tun: rx batching Stefan Hajnoczi <stefanha@gmail.com> - 2017-01-05 10:30 +0100
csiph-web