[PATCH 2/2] Fix warning during compilation

From	ivan.stoyanov@amk-drives.bg
Newsgroups	linux.kernel
Subject	[PATCH 2/2] Fix warning during compilation
Date	2017-01-03 09:30 +0100
Message-ID	<sVsDM-3nL-7@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

From: amk <amk@amk-drives.bg>

drivers/dma/ipu/ipu_irq.c: In function 'ipu_irq_fn':
drivers/dma/ipu/ipu_irq.c:342:4: warning: 'irq' may be used uninitialized in this function [-Wmaybe-uninitialized]

Signed-off-by: amk <amk@amk-drives.bg>
---
 drivers/dma/ipu/ipu_irq.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/dma/ipu/ipu_irq.c b/drivers/dma/ipu/ipu_irq.c
index 3f9477c..fae6ef8a 100644
--- a/drivers/dma/ipu/ipu_irq.c
+++ b/drivers/dma/ipu/ipu_irq.c
@@ -330,15 +330,15 @@ static void ipu_irq_fn(struct irq_desc *desc)
 
 			raw_spin_lock(&bank_lock);
 			map = src2map(32 * i + line);
-			if (map)
-				irq = map->irq;
-			raw_spin_unlock(&bank_lock);
 
 			if (!map) {
+				raw_spin_unlock(&bank_lock);
 				pr_err("IPU: Interrupt on unmapped source %u bank %d\n",
 				       line, i);
 				continue;
 			}
+			irq = map->irq;
+			raw_spin_unlock(&bank_lock);
 			generic_handle_irq(irq);
 		}
 	}
-- 
2.7.4

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH 2/2] Fix warning during compilation ivan.stoyanov@amk-drives.bg - 2017-01-03 09:30 +0100
  Re: [PATCH 2/2] Fix warning during compilation Arnd Bergmann <arnd@arndb.de> - 2017-01-03 23:00 +0100
    Re: [PATCH 2/2] Fix warning during compilation Ivan Stoyanov <ivan.stoyanov@amk-drives.bg> - 2017-01-04 07:40 +0100

csiph-web